Closed Bug 1078265 Opened 6 years ago Closed 6 years ago

Add Treeherder support for the new split APK Android job names

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: jlund)

References

Details

Attachments

(5 files)

No description provided.
Summary: Add support for the new split APK Android job names → Add Treeherder support for the new split APK Android job names
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Priority: P1 → P2
Attached file UI part
Attachment #8508684 - Flags: review?(cdawson)
Attached file Service part
Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/c60baf450cde
Attachment #8508685 - Flags: review?(cdawson)
Comment on attachment 8508684 [details] [review]
UI part

Mauro said he was fine landing without review for these types of changes.
Attachment #8508684 - Flags: review?(cdawson)
Attachment #8508685 - Flags: review?(cdawson)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attached file ui part
[UI part]

we are now changing how we split. based off https://bugzilla.mozilla.org/show_bug.cgi?id=1078265#c6 I think I can just land this when ready (assuming I have permissions)
Assignee: emorley → jlund
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file service part 2
bear with this github noob, I think I am doing this correctly.

At any rate, if r+, how do I land this and the UI part: https://bugzilla.mozilla.org/show_bug.cgi?id=1078265#c7 ?

fwiw I don't think I have write access to these repos as I was unable to push a feature branch to the official mozilla treeherder repos (I had to fork)
Attachment #8533976 - Flags: review?(cdawson)
Hey Ed-- would you take a look at this PR and see if it looks good to you?
Flags: needinfo?(emorley)
Attachment #8533976 - Flags: review?(cdawson) → review?(emorley)
Comment on attachment 8533976 [details] [review]
service part 2

Thank you for adding back api10, agree it needs to stick around for a bit (particularly for the UI). Have left a few comments on the PRs, other than those will be good to merge. Re-request review to remind me to merge them for you :-)
Flags: needinfo?(emorley)
Attachment #8533976 - Flags: review?(emorley)
Comment on attachment 8533976 [details] [review]
service part 2

thanks for the reviews! re-requesting review with fixes in place. reminder ping to please merge branch if everything looks good :)
Attachment #8533976 - Flags: review?(emorley)
Comment on attachment 8533971 [details] [review]
ui part

reminder ping to please merge branch on my behalf if everything looks good :)
Attachment #8533971 - Flags: review?(emorley)
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/c92677f82bc5aa30e17edea56234d66851e474ee
Bug 1078265 - Add support for split Android APK - splits off api-11 now

https://github.com/mozilla/treeherder-ui/commit/33b9fd96f46e71167a8dcddcfdd130a5195a8452
Merge pull request #296 from lundjordan/bug-1078265-support-split-apk

Bug 1078265 - Add support for split Android APK - splits off api-11 now
Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/c7a7ad50ed3e7fcbe5788926bfe6563ee04119c9
Bug 1078265 - Add support for split Android APK - splits off api-11 now

https://github.com/mozilla/treeherder-service/commit/150157490726ac05536c80ab18a9059a6eb4c5d9
Merge pull request #295 from lundjordan/bug-1078265-support-split-apk

Bug 1078265 - Add support for split Android APK - splits off api-11 now
Attachment #8533971 - Flags: review?(emorley) → review+
Attachment #8533976 - Flags: review?(emorley) → review+
Thanks :-)
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
It turns out mergeing to main repo != live in prod.

my mistake. rather than a full backout, I suggest we trick tbpl/treeherder into thinking we are still doing api-10 but really, they will be the api-11 builds

I'd prefer this so we don't block on split-apk but understand it might be a point of confusion, at least until monday.
Attachment #8535891 - Flags: review?(coop)
Comment on attachment 8535891 [details] [diff] [review]
141212_splitapk_use-old-api-10-in-base-name-bbotcfgs.patch

Review of attachment 8535891 [details] [diff] [review]:
-----------------------------------------------------------------

needs email as discussed in #releng
Attachment #8535891 - Flags: review?(coop) → review+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/032a461bf9834d5a179482b50cb69377a55b4238
Bug 1078265 - Add support for split Android APK jobs

Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/c60baf450cde

https://github.com/mozilla/treeherder/commit/c92e9401efc712059e10cd9fb673fd87240c4792
Bug 1078265 - Add support for split Android APK - splits off api-11 now

https://github.com/mozilla/treeherder/commit/aed1fd2631ca200d1a4b2213954cb992d17c2310
Merge pull request #296 from lundjordan/bug-1078265-support-split-apk

Bug 1078265 - Add support for split Android APK - splits off api-11 now
You need to log in before you can comment on or make changes to this bug.