1078266 - Add TBPL support for the new split APK Android job names

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Comment 1

[Ed Morley [:emorley]]

Waiting on the final buildername choices in bug 1073772.

https://hg.mozilla.org/webtools/tbpl/file/default/js/Data.js#l589

Comment 2

[Ryan VanderMeulen [:RyanVM]]

From bug 1073772:

Android armv7 API 9 %(branch)s %(job)
Android armv7 API 9 %(branch)s debug %(job)
Android armv7 API 10+ %(branch)s %(job)
Android armv7 API 10+ %(branch)s debug %(job)

Not clear what (if anything) needs changing for x86 and armv6. But I'll at least get started on implementing the above for now.

Comment 3

[Richard Newman [:rnewman]]

ARMv6 support is dead, so that's academic.

x86 is unchanged -- 9+, but that doesn't need to be called out.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Per discussion in bug 1073772, we're going to go with:

Android armv7 API 9 %(branch)s %(job) (builds and tests)
Android armv7 API 9 %(branch)s debug %(job)

Android armv7 API 10+ %(branch)s %(build)
Android 4.0 armv7 API 10+ %(branch)s %(test)
Android armv7 API 10+ %(branch)s debug %(build)
Android 4.0 armv7 API 10+ %(branch)s debug %(test)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

My regex tester says this correctly matches various job names based off comment 4 without breaking any existing ones. I'm of course always open to feedback, though :)

I tried to be forward-thinking about the display names for future API+Android build+test combinations. Unfortunately, including Armv7 in the names made them longer than any other jobs, so I dropped that. Armv8 is far enough out that it's probably not a huge deal anyway.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8502726 [details] [diff] [review]
patch

lgtm :-)

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> Unfortunately, including Armv7 in the
> names made them longer than any other jobs, so I dropped that. Armv8 is far
> enough out that it's probably not a huge deal anyway.

Yeah agreed it's unneccesary

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/webtools/tbpl/rev/c60baf450cde

Comment 8

[Ryan VanderMeulen [:RyanVM]]

In production.

Comment 9

[Jordan Lund (:jlund)]

Attachment: we are now splitting off api-9 and api-11

context: https://bugzilla.mozilla.org/show_bug.cgi?id=1073772#c82

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8533982 [details] [diff] [review]
we are now splitting off api-9 and api-11

Review of attachment 8533982 [details] [diff] [review]:
-----------------------------------------------------------------

We need to keep the API10+ lines as well for compatibility with older jobs since data is retained for 30 days.

Comment 11

[Jordan Lund (:jlund)]

Attachment: add api 11 - keep api 10 for legacy

thanks.

new patch with api 10 kept in.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8534537 [details] [diff] [review]
add api 11 - keep api 10 for legacy

Review of attachment 8534537 [details] [diff] [review]:
-----------------------------------------------------------------

I think you forgot to qref :)

Comment 13

[Jordan Lund (:jlund)]

Attachment: add api 11 and keep api 10 for realz

I blame mozflu

round 3, fight.

Comment 14

[Jordan Lund (:jlund)]

Comment on attachment 8534551 [details] [diff] [review]
add api 11 and keep api 10 for realz

https://hg.mozilla.org/webtools/tbpl/rev/8d92681464e1

Comment 15

[Ed Morley [:emorley]]

Part 2 in production.