1078271 - [Top sites] Top Sites aren't shown in correct order

Status: RESOLVED DUPLICATE of bug 1078202

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Loli (:lolimartinezcr)]

STRs:
1. Completing the FTE with a configured sim with pin inserted
2. Open browser app
3. Open top sites list ->  The web page opened displayed in first position 
4. open a web page which is not added to the top sites list (in my case: www.youtube.com)

Actual result:
The web page opened in the step 4 is displayed but *not* first position and the top sites in the step 3 *not* lose a position.

Expected result:
The web page opened in the step 4 is displayed and first position and the top sites in the step 3  lose a position.

Comment 1

[Loli (:lolimartinezcr)]

Flame
2.2
User
Gecko-9968a8f
Gaia-778ebac

Comment 2

[Marcelino Veiga Tuimil [:sonmarce]]

[Blocking Requested - why for this release]: It was working en 2.0 as described in user story

Comment 3

[Marcelino Veiga Tuimil [:sonmarce]]

User Story is described in bug 1009633

Comment 4

[Kevin Grandon :kgrandon]

Hey Loli - The algorithm may have changed more in 2.1 here. I've tested the top sites functionality today and it seems to work. Can you attach some screenshots here to verify the steps taken/expected results here?

Comment 5

[Kevin Grandon :kgrandon]

Triage: We're looking for a video here if possible and also the configuration used to define top sites.

Comment 6

[Loli (:lolimartinezcr)]

(In reply to Kevin Grandon :kgrandon from comment #4)
> Hey Loli - The algorithm may have changed more in 2.1 here. I've tested the
> top sites functionality today and it seems to work. Can you attach some
> screenshots here to verify the steps taken/expected results here?

I have attached image about order.

Steps done:
1.Tap top site (facebook) -> duplicate Facebook page.
2. write url: www.youtube.es

In history you can see order of page and in topsite you can see facebook page is first.

Comment 7

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #6)
> (In reply to Kevin Grandon :kgrandon from comment #4)
> > Hey Loli - The algorithm may have changed more in 2.1 here. I've tested the
> > top sites functionality today and it seems to work. Can you attach some
> > screenshots here to verify the steps taken/expected results here?
> 
> I have attached image about order.
> 
> Steps done:
> 1.Tap top site (facebook) -> duplicate Facebook page.
> 2. write url: www.youtube.es
> 
> In history you can see order of page and in topsite you can see facebook
> page is first.

This scenario is reproducible when top sites is redirect.

If a topsite is "www.facebook.com" when user taps in this top site appear other page (page 1) in list of topsite and when after user navegates to other url, page 1 is in first position.


Note: topsites_movistar.json file

{
"topSites": [
{
"title": "Movistar",
"url": "http://www.movistar.es",
"tilePath": "resources/movistar.ico"
},
{
"title": "Facebook",
"url": "www.facebook.com",
"tilePath": "resources/movistar.ico"
}
]

Comment 8

[Loli (:lolimartinezcr)]

Attachment: 2014-10-08-11-19-08.png

Comment 9

[Ben Francis [:benfrancis]]

I'm not 100% clear on what the bug is you're describing here and it's difficult for me to test without a configuration for a specific SIM.

It appears from the code that preloaded top sites are given a frecency of 0. Any organic page visits should get at least a frecency of 1, and therefore appear above the preloaded ones. Is that not happening?

Dale has a patch in bug 1078202 which will give single variant top sites a frecency of -1, and build top sites a frecency of -2. I don't know whether his patch will change the behaviour you're seeing in this bug.

Comment 10

[Dale Harvey (:daleharvey)]

Ben to test customisations, put a sim in your device, check logcat and see "dont have configuration for XXX-XXX", add that to customization/variant.json, then flash with GAIA_DISTRIBUTION_DIR=customization/ make reset-gaia

I will verify the behaviour once 107802 lands, however the behaviour is as was in the previous browser (As ben said), sim customisations get -1, build ones -2, visits start at 1, if you have facebook (with redirect as a sim customisation and say mozilla.org), then click on the facebook top site and visit youtube, I would expect

youtube=1 | facebook=1 | facebook topsite url=0 | mozilla.org-1

Ben feel free to assign this to me since its related to my other patch

Comment 11

[Marcelino Veiga Tuimil [:sonmarce]]

Not sure if it is related to single variant or the way frecency is calculated in case of redirects. Apparently redirected preconfigured URL has higher frecency than a new URL being visited later on.

Comment 12

[Dale Harvey (:daleharvey)]

So that would happen currently, before the sim changes we configured preloaded sites with an index of 0, that means when you click on a redirect both the top site url and the url redirected to will have a frecency index of 1, so they have the same index and order is undefined (the top site url may well be before the url redirected to)

After the changes we will get the above behaviour where the url that redirect starts at -1, same as the original browser implementation, so marking as a dupe

Comment 13

[Gregor Wagner [:gwagner]]

Lets verify after bug 1078202 lands.

Comment 14

[Loli (:lolimartinezcr)]

(In reply to Ben Francis [:benfrancis] from comment #9)
> I'm not 100% clear on what the bug is you're describing here and it's
> difficult for me to test without a configuration for a specific SIM.
> 
> It appears from the code that preloaded top sites are given a frecency of 0.
> Any organic page visits should get at least a frecency of 1, and therefore
> appear above the preloaded ones. Is that not happening?
> 
> Dale has a patch in bug 1078202 which will give single variant top sites a
> frecency of -1, and build top sites a frecency of -2. I don't know whether
> his patch will change the behaviour you're seeing in this bug.

When you tap in a "topsite" that it has redirected (adding a new page in top site list in first position) if after user browses to other page (writes "www.youtube.com") , this page isn't in first position.