Closed
Bug 1078327
Opened 10 years ago
Closed 10 years ago
FF needs correct check PointerCapture for correct firing pointerover/pointerout events
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: alessarik, Assigned: alessarik)
References
Details
Attachments
(2 files, 1 obsolete file)
1.66 KB,
patch
|
smaug
:
review+
mbrubeck
:
feedback+
|
Details | Diff | Splinter Review |
6.94 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822
Steps to reproduce:
If users want set pointer capture on element, which contain another elements, FF should correct detecting cases for firing pointerover/pointerout events.
Actual results:
If pointer crosses boundaries of internal elements, pointerout event was fired at element which have pointercapture.
Expected results:
pointerout event should be fired only in case if pointer crosses external boundaries of capturing content.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
+ Add correct checking for detect elements with contents
Attachment #8500505 -
Flags: review?(bugs)
Attachment #8500505 -
Flags: feedback?(mbrubeck)
Comment 2•10 years ago
|
||
Comment on attachment 8500505 [details] [diff] [review]
check_capturing_content_ver1.diff
We need a test for this.
Attachment #8500505 -
Flags: review?(bugs) → review+
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Component: Untriaged → General
Ever confirmed: true
Product: Firefox → Core
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #2)
> We need a test for this.
I will try, but I am very doubt that I can provide auto test.
Assignee | ||
Comment 4•10 years ago
|
||
+ Test for correct detecting capturing content
Attachment #8501675 -
Flags: review?(bugs)
Attachment #8501675 -
Flags: feedback?(mbrubeck)
Assignee | ||
Comment 5•10 years ago
|
||
Test without patch:
https://tbpl.mozilla.org/?tree=Try&rev=27f83657a1cd
Test with patch:
https://tbpl.mozilla.org/?tree=Try&rev=799537b8932d
Comment 6•10 years ago
|
||
I see failures on try.
Comment 7•10 years ago
|
||
Comment on attachment 8501675 [details] [diff] [review]
check_capturing_content_test_ver1.diff
Please fix the failures.
Attachment #8501675 -
Flags: review?(bugs)
Attachment #8501675 -
Flags: review-
Attachment #8501675 -
Flags: feedback?(mbrubeck)
Updated•10 years ago
|
Attachment #8500505 -
Flags: feedback?(mbrubeck) → feedback+
Assignee | ||
Comment 8•10 years ago
|
||
+ Changes: Add correct finish for test
Attachment #8501675 -
Attachment is obsolete: true
Attachment #8506693 -
Flags: review?(bugs)
Attachment #8506693 -
Flags: feedback?(mbrubeck)
Assignee | ||
Comment 9•10 years ago
|
||
Test without patch:
https://tbpl.mozilla.org/?tree=Try&rev=585b9e3e2b4e
Test with patch:
https://tbpl.mozilla.org/?tree=Try&rev=8f2c1924d40a
Updated•10 years ago
|
Attachment #8506693 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 10•10 years ago
|
||
If nobody have objections, I put checkin flag.
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/458b83f2eaf4
https://hg.mozilla.org/integration/mozilla-inbound/rev/70868ad1299f
Assignee: nobody → alessarik
Keywords: checkin-needed
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/458b83f2eaf4
https://hg.mozilla.org/mozilla-central/rev/70868ad1299f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Attachment #8506693 -
Flags: feedback?(mbrubeck)
You need to log in
before you can comment on or make changes to this bug.
Description
•