1078409 - Fix or suppress talos pageset JavaScript errors

Status: RESOLVED DUPLICATE of bug 998794

(Testing :: Talos, defect)

Description

[Ed Morley [:emorley]]

In all green talos tp5 jobs, there is lots of log spam from javascript errors, which shows in the TBPL/treeherder annotated summary. The sheer volume of the log lines (and the fact that they occur in passing runs) is partly contributing to the DB consumption issues in bug 1078392.

Now we're going to make some treeherder changes like capping the max log error lines stored in the DB, but it would be good to clean this up in talos too.

eg:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64-pgo/1412206211/mozilla-central_ubuntu64_hw_test-tp5o-pgo-bm105-tests1-linux-build211.txt.gz

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=440013&repo=mozilla-central (will hang for a bit)

18:34:46    ERROR -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/static.guim.co.uk/static/103540/common/scripts/gu-core.js, line 28: SyntaxError: missing ; before statement
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 177: ReferenceError: guardian is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 639: ReferenceError: ensurePackage is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 676: ReferenceError: OAS_AD is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 2752: ReferenceError: OAS_AD is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 4452: ReferenceError: OAS_AD is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 5970: ReferenceError: OAS_AD is not defined
18:34:46     INFO -  JavaScript error: http://localhost/page_load_test/tp5n/guardian.co.uk/www.guardian.co.uk/index.html, line 6043: ReferenceError: voidScript is not defined

Comment 1

[Ed Morley [:emorley]]

18:36 <jmaher> edmorley: can you look at a tp5 run in inbound in the last hour?
18:37 <jmaher> edmorley: all the javascript errors should be supressed

Which change suppressed these? :-)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

it was here: http://hg.mozilla.org/build/talos/rev/a8ce24a66add

Comment 3

[Ed Morley [:emorley]]

Ah great, thank you :-)