Tag parsing for .lang files should allow dash character

RESOLVED FIXED

Status

www.mozilla.org
L10N
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: flod, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

A tag like "contribute-2015" breaks completely the tag parsing for lang file (following tags are ignored).

We should allow dashes in tags, even if we usually use underscores.
Mentor: pmac@mozilla.com
Whiteboard: [good first bug]

Comment 1

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/0607768e187416bc398046912b7ba53bd4bb4967
Bug 1078655: update regex in dotlang parser to allow dashes

https://github.com/mozilla/bedrock/commit/af8984f2aba722c458bf95e0320fa09fc181ae49
Merge pull request #2344 from pascalchevrel/bug-1078655-allow_dash_character_in_langfile_tags

Bug 1078655: update regex in dotlang parser to allow dashes
Please check the "mentored" and whiteboard fields before working on a good first bug. We need bugs like this for contributor on-boarding and I continue to be unable to give them any because they're all taken by long-time contributors.
Mentor: pmac@mozilla.com
Whiteboard: [good first bug]
I wrote the patch ans did the PR before you added the [good first bug] tag tout this bug.
Fair enough. We just need good-first-bugs. If you can help save some things like this for people who want to help I'd really appreciate it. Apologies for taking the bug comments off-topic.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.