TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | value is not a non-null object

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
mossop
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Jetpack tests are failing right now.

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | value is not a non-null object
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Test timed out (after: window is private)
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected windows open
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected tabs open
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-selection.test PBPW Selection Listener | Test output exceeded timeout (300s).
(Assignee)

Comment 1

3 years ago
Bug 1039500 made _getTabForBrowser throw an exception when you pass it something that isn't a browser. Previously it would just return null.
Blocks: 1039500
(Assignee)

Comment 2

3 years ago
Created attachment 8500644 [details] [review]
pull request
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Comment on attachment 8500644 [details] [review]
pull request

r=zombie over IRC
Attachment #8500644 - Flags: review+

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1e33a6c43e313c49cbfe329720d4ab163c70de08
Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument.

https://github.com/mozilla/addon-sdk/commit/7b2f081dab81051430f0018f198528c2f0725d79
Merge pull request #1673 from Mossop/bug1078665

Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument. r=zombie
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(In reply to Dave Townsend [:mossop] from comment #3)
> r=zombie over IRC

i was just looking at it, and agree with comment in the PR..
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/5578b160f514
https://hg.mozilla.org/mozilla-central/rev/5578b160f514
You need to log in before you can comment on or make changes to this bug.