1078665 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | value is not a non-null object

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dave Townsend [:mossop]]

Jetpack tests are failing right now.

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | value is not a non-null object
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Test timed out (after: window is private)
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected windows open
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected tabs open
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-selection.test PBPW Selection Listener | Test output exceeded timeout (300s).

Comment 1

[Dave Townsend [:mossop]]

Bug 1039500 made _getTabForBrowser throw an exception when you pass it something that isn't a browser. Previously it would just return null.

Comment 2

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8500644 [details] [review]
pull request

r=zombie over IRC

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1e33a6c43e313c49cbfe329720d4ab163c70de08
Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument.

https://github.com/mozilla/addon-sdk/commit/7b2f081dab81051430f0018f198528c2f0725d79
Merge pull request #1673 from Mossop/bug1078665

Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument. r=zombie

Comment 5

[Tomislav Jovanovic :zombie]

(In reply to Dave Townsend [:mossop] from comment #3)
> r=zombie over IRC

i was just looking at it, and agree with comment in the PR..

Comment 6

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/5578b160f514

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5578b160f514