Closed Bug 1078665 Opened 5 years ago Closed 5 years ago
TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel
.test Get Window | value is not a non-null object
Jetpack tests are failing right now. TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | value is not a non-null object TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Test timed out (after: window is private) TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected windows open TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-panel.testGetWindow | Should not be any unexpected tabs open TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-selection.test PBPW Selection Listener | Test output exceeded timeout (300s).
Bug 1039500 made _getTabForBrowser throw an exception when you pass it something that isn't a browser. Previously it would just return null.
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Comment on attachment 8500644 [details] [review] pull request r=zombie over IRC
Attachment #8500644 - Flags: review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1e33a6c43e313c49cbfe329720d4ab163c70de08 Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument. https://github.com/mozilla/addon-sdk/commit/7b2f081dab81051430f0018f198528c2f0725d79 Merge pull request #1673 from Mossop/bug1078665 Bug 1078665: Ignore exceptions thrown out of getBrowserForDocument. r=zombie
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Dave Townsend [:mossop] from comment #3) > r=zombie over IRC i was just looking at it, and agree with comment in the PR..
You need to log in before you can comment on or make changes to this bug.