1078672 - [Clock] Alarm sound becomes "No Sound" after OTA upgrade from 2.0 to 2.1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20141006_AfterOTA.txt

Description:
When the user sets an alarm with sound, the sound setting defaults to "No Sound" after OTA upgrade. The alarm sound options are different between 2.0 and 2.1. However, the alarm setting shouldn't default to "No Sound" after OTA upgrade.

Repro Steps:
1) Update a Flame device to 2.0 BuildID: 20141006000202
2) Change update channel and url on device to appropriate 2.1 build (20141006000205).
3) Open Clock app.
4) Create an alarm with sound.
5) Perform OTA upgrade.
6) After the upgrade is complete, open Clock app again.
7) Select the previously created alarm.

Actual:
The alarm sound is set to "No Sound".

Expected:
The sound setting is same as before the OTA, or at least set to the default setting, which is "Awake".

[Before OTA - Flame 2.0]
  
Environmental Variables:
Device: Flame 2.0 (319mb, Full Flash)
BuildID: 20141006000202
Gaia: 092d2b7678774c8b0b06dca0e0a8119e9eafdec3
Gecko: 69ca61f7edf3
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
  
[After OTA - Flame 2.1]

Environmental Variables:
Device: Flame 2.1
BuildID: 20141006000205
Gaia: 778ebac47554e1c4b7e9a952d73e850f58123914
Gecko: c4a4b04c617c
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro Frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/11458/
See attached: logcat, screenshot

Comment 1

[Yeojin Chung [:YeojinC]]

Attachment: AlarmSound.png

Comment 2

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce after OTA upgrade from 2.1 to 2.2:

[Before OTA - Flame 2.1]

Environmental Variables:
Device: Flame 2.1 (319mb, Full Flash)
BuildID: 20141006000205
Gaia: 778ebac47554e1c4b7e9a952d73e850f58123914
Gecko: c4a4b04c617c
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

[After OTA - Flame 2.2]

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141006040204
Gaia: 470826d13ae130a5c3d572d1029e595105485fb0
Gecko: e0d714f43edc
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The alarm sound is same as before the upgrade.

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

nominating this to block, if a user does an update and the alarm tone defaults to "No Sound" instead of a default tone, the user could miss important alarms.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Edward, could you please look at this?

Comment 5

[Gerry Chang [:gchang]]

According to bug #1046399, most alarms in 2.0 are removed except for ac_humming_waves & ac_into_the_void. So, I personally think if user chooses other sound rather than these 2 sounds, the sound user chooses disappears after OTA, it will be changed to "No Sound".

Comment 6

[Dylan Oliver [:doliver]]

triage: As this would render a great many alarms useless after migration to 2.1, we feel that this needs to be fixed. Minimally, we should fire off the default sound for any alarm that was using a tone that we obsoleted in the move to 2.1.

Comment 7

[Marcus Cavanaugh [:mcav]]

Attachment: gaia pr

We already map over the alarms during startup to normalize database entries, so the fix for this is simple: at startup, if the sound filename isn't available, default to something.

Comment 8

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8508700 [details] [review]
gaia pr

LGTM! clean, documented and with unit tests!

Comment 9

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/d3fbba6bc6f83775e0594cb4effad1dc4d406402

Comment 10

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8508700 [details] [review]
gaia pr

[Approval Request Comment]

Due to shared sound changes from 2.0->2.1, users' previous alarm sounds may be unavailable. This patch causes those missing sounds to default to a 2.1 sound, whereas without this patch, the sound defaults to "no sound", meaning users may miss their alarm.

[Bug caused by] (feature/regressing bug #): n/a
[User impact] if declined: Users may not hear their alarm go off
[Testing completed]: unit test + manual verification
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/cd86283bd7bbffe06cc4571534d72fd4f935d003

Comment 12

[Duane Dixon [:ddixon]]

Issue is verified fixed in Flame 2.1, 2.2 (Full Flash, nightly). 

Actual Results: Alarms save correctly with OTA update. 

Device: Flame 2.1
Build ID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame Master
Build ID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Issue is verified fixed in Flame 2.1, 2.2 (Full Flash, nightly).