Closed
Bug 1078847
Opened 10 years ago
Closed 10 years ago
GenerateAsymmetricKeyTask fails if no private key usages are passed
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
2.30 KB,
patch
|
rbarnes
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Small typo from bug 1037892. Also I think we should modify the condition to allow generating a key pair where only the public *or* the private key has any usages. This behavior isn't defined in the spec afaict, should it be added? Blocking DH as this makes a few tests fail there.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8500736 -
Flags: review?(rlb)
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Tim Taubert [:ttaubert] from comment #0) > This behavior isn't defined in the spec afaict, should it be added? I was referring to behavior of bailing out and making .generateKey() fail if there are no valid usages for any of the keys in the key pair.
Assignee | ||
Comment 3•10 years ago
|
||
Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ee02b0672bc6
Updated•10 years ago
|
Attachment #8500736 -
Flags: review?(rlb) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c095b4e178c
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c095b4e178c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8500736 [details] [diff] [review] 0007-Bug-1078847-GenerateAsymmetricKeyTask-should-allow-g.patch Approval Request Comment [Feature/regressing bug #]: bug 1037892 [User impact if declined]: Asymmetric key generation fails when the private key h as no usage. [Describe test coverage new/current, TBPL]: includes a test that works fine on m-c [Risks and why]: Low risk. [String/UUID change made/needed]: None. We need this for bug 1034856.
Attachment #8500736 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8500736 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a0b472565f9e
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•