107891 - nsMetaCharsetObserver::End() uses getService (in ParserService obj) to shutdown; suggest registering WeakRef

Status: VERIFIED DUPLICATE of bug 133383

(Core :: Internationalization, defect)

Description

[David Epstein]

this is causing warning msg when shutting down Mozilla. See bug 107391).
reproduced in 10/27 debug mozilla build.
1. Set break points in nsWarning messages in nsComponentManager.cpp;
nsComponentManagerImpl::GetService() and
nsComponentManagerImpl::GetServiceByContractID() (currently lines 1750 & 2075).
2. Launch Mozilla with F5.
3. Quit Mozilla.
4. F5 (twice) until you see stack trace including destructor for
nsMetaCharsetObserver()
5. Doubleclick on line above ~nsMetaCharsetObserver:
nsMetaCharsetObserver::End(nsMetaCharsetObserver * const 0x00e640fc) line 429 +
28 bytes.
Result: Creates ParserServer object by calling do_GetService() to shutdown
nsMetaCharsetObserver service. Also, returns "out of memory" value when
parserService object isn't created (couldn't there be other error conditions as
well).
Suggest registering a weakReference. Maybe just return NS_OK when the object is
created.

Comment 1

[Frank Tang]

not quite sure what does this mean.

Comment 2

[Frank Tang]

shanjian- can you take a look at this one. Not sure how important this is.

Comment 3

[Shanjian Li]

accepting.

Comment 4

[timeless]

*** This bug has been marked as a duplicate of 133383 ***

Comment 5

[David Epstein]

why is this being duped to a later bug that looks to be the same?

Comment 6

[Teruko Kobayashi]

Verified as dup.