1079120 - Make ToNumber(string) support binary and octal literals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[ziyunfei]

>Number('0b11')  // 3
>Number('0o77')  // 63

https://bugs.ecmascript.org/show_bug.cgi?id=1584
https://bugs.ecmascript.org/show_bug.cgi?id=3259

Comment 1

[ziyunfei]

Attachment: bug-1079120.patch

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8500921 [details] [diff] [review]
bug-1079120.patch

Review of attachment 8500921 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thanks!

I'm not sufficiently convinced it is web compatible to just land it, though. Asking jorendorff for a decision on that. Please hold off on landing until then.

::: js/src/tests/ecma_6/Number/ToNumber.js
@@ +18,5 @@
> +assertEq(+"0o66", 54);
> +
> +if(typeof getSelfHostedValue === "function"){
> +    assertEq(getSelfHostedValue("ToNumber")("0b11"), 3);
> +    assertEq(getSelfHostedValue("ToNumber")("0o66"), 54);

Nice!

Comment 3

[Tom S [:evilpie]]

I am pretty sure this is web compatible, Chrome seems to have this already.

Comment 4

[ziyunfei]

(In reply to Tom Schuster [:evilpie] from comment #3)
> I am pretty sure this is web compatible, Chrome seems to have this already.

Chrome has experimented this for one year, and seems no breakage reported so far.

https://codereview.chromium.org/19300002
https://codereview.chromium.org/626153002

Comment 5

[Till Schneidereit [:till]]

Comment on attachment 8500921 [details] [diff] [review]
bug-1079120.patch

Review of attachment 8500921 [details] [diff] [review]:
-----------------------------------------------------------------

> Chrome has experimented this for one year, and seems no breakage reported so far.

Ok, that does convince me; let's land this.

ziyunfei, can you make sure the patch still applies and passes tests and then set checkin-needed?

::: js/src/tests/ecma_6/Number/ToNumber.js
@@ +18,5 @@
> +assertEq(+"0o66", 54);
> +
> +if(typeof getSelfHostedValue === "function"){
> +    assertEq(getSelfHostedValue("ToNumber")("0b11"), 3);
> +    assertEq(getSelfHostedValue("ToNumber")("0o66"), 54);

Nice!

Comment 6

[ziyunfei]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1a0a13975435

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e3582d234c1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e3582d234c1