"DEBUG=1 make" doesn't work on ubuntu 12.04 x64

RESOLVED FIXED in 2.1 S7 (24Oct)

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lchang, Assigned: ochameau)

Tracking

unspecified
2.1 S7 (24Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8500905 [details]
build script log

After Bug 1002545 landed [1], the building process gets stuck when I try to run "DEBUG=1 make". Please refer to the attachment for the logs.

[1] https://github.com/mozilla-b2g/gaia/commit/529298abcf6eec7788dcab6d9932824e8bf4ad68
(Reporter)

Updated

4 years ago
See Also: → bug 1051814
As Alexandre mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1002545#c91. It seems a problem in download.jsm. We could replace it by old one to solve this problem.

Maybe Alexandre could help with us replace Downloads.jsm usage with saveURI.
Flags: needinfo?(poirot.alex)
Another question is I still have no idea why the download.jsm caused failures on ubuntu12.04 but passed on ubuntu14.04.
(Assignee)

Comment 3

4 years ago
Created attachment 8501780 [details] [review]
Pull request 24949

I just tested download additional extensions and it seems to work just fine.
Ricky, could you test this patch against svoperapps? It is also using download-manager and I would like to ensure it also keep working fine.

I'm wondering if the usage of Downloads.jsm relates to the various exceptions about nsHandlerService.js:120 we can see when building gaia, as well as the intermittent stack reported in bug 1070622. If that's the case that would be a great win!
Attachment #8501780 - Flags: feedback?(ricky060709)
Flags: needinfo?(poirot.alex)
Nice!

Luke, do you want to give it a try on your ubuntu12.04?
Flags: needinfo?(lchang)
(Reporter)

Comment 5

4 years ago
Cool! That patch works. Thanks a lot.
Flags: needinfo?(lchang)
Comment on attachment 8501780 [details] [review]
Pull request 24949

Patch works properly for me and I didn't see those strange logs from bug 1070622.
Attachment #8501780 - Flags: feedback?(ricky060709) → feedback+
(Assignee)

Comment 7

4 years ago
Comment on attachment 8501780 [details] [review]
Pull request 24949

Fixed some issue reported by the linter.
Given the positive feedback, I think we can move forward with this patch.
It may also fix bug 1070622.
Attachment #8501780 - Flags: review?(gduan)
(Assignee)

Updated

4 years ago
Assignee: nobody → poirot.alex
Comment on attachment 8501780 [details] [review]
Pull request 24949

Basically, it looks fine.
Just one question left in github.
Attachment #8501780 - Flags: review?(gduan) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/1d8247277b62e3a72837b6266a01321752236f0e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.