1079215 - Invalid warning when user taps in update available with disabled wifi connection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Loli (:lolimartinezcr)]

Flame
User
2.2
Gecko-9968a8f
Gaia-778ebac

Pre-requisites:
1. Wifi disabled.
2. "app.update.2g.enabled" = true
 "app.update.wifi-prioritized" = true
3. Update available.

STRs:
1. User drag and drop utility try.
2. Tap "1 update available"

Actual result:
User can see a warning "Updates are downloaded via data connection when Wi-Fi is not availabe. Additional data charges may apply." 

Expected result
This warning shouldn't appear.

Comment 1

[Loli (:lolimartinezcr)]

Attachment: 2014-10-07-13-34-11.png

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Warning is not longer shown

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: no--warning.png

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8502328 [details] [review]
Warning is not longer shown

I don't think this is the right fix (removing the warning outright).

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We probably need more context on this bug. Is this a recent regression? What's the regressed bug?

According to the commit log the warning was added all the way back at bug 824575. Have we changed the behavior somewhere to cause this bug?

Comment 6

[Manuel Casas Barrado [:mancas]]

Hey Tim, according to bug1039501, this warning should not appear here. Instead, the warning will be displayed once the user is going to download the update.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

In that case please ask etienne for review then -- I am not sure if the removal is complete here. Thanks!

Comment 8

[Jenny Lee]

Comment on attachment 8502329 [details]
no--warning.png

Hi Manuel, 
It looks ok from the screen but I will need to review the entire behavior on phone to be safe. Please provide me github link, thanks!

Comment 9

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8502328 [details] [review]
Warning is not longer shown

Hey Etienne, could you take a look at the PR and tell us if everything is ok?

Thanks!

Comment 10

[Manuel Casas Barrado [:mancas]]

(In reply to Jenny Lee from comment #8)
> Comment on attachment 8502329 [details]
> no--warning.png
> 
> Hi Manuel, 
> It looks ok from the screen but I will need to review the entire behavior on
> phone to be safe. Please provide me github link, thanks!

Hi Jenny, here you have the link to the PR:

https://github.com/mozilla-b2g/gaia/pull/24980

Thanks!

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8502328 [details] [review]
Warning is not longer shown

lgtm, sorry I missed it while reviewing bug 1039501.

Comment 12

[Jenny Lee]

Attachment: no internet connection.png

Hi Manuel,
Not sure why but see attached for what I actually see when tap on system update notification with no internet connection. I think the message shown is proper in this case, but the download button is missing (note that this dialog format is not defined in building blocks, but we can discuss that in separate bug in the future). I would like to have it back in gray out form.
Let me know if this is a bug or something else. Thanks!

Comment 13

[Manuel Casas Barrado [:mancas]]

(In reply to Jenny Lee from comment #12)
> Created attachment 8504008 [details]
> no internet connection.png
> 
> Hi Manuel,
> Not sure why but see attached for what I actually see when tap on system
> update notification with no internet connection. I think the message shown
> is proper in this case, but the download button is missing (note that this
> dialog format is not defined in building blocks, but we can discuss that in
> separate bug in the future). I would like to have it back in gray out form.
> Let me know if this is a bug or something else. Thanks!

Hi Jenny, I'm not sure about the expected behaviour here since I've not implemented it and I don't know if we have specs for this part. Could you provide the specs needed to handle this situation?

I suggest to remove this notification and when user tap in download, a prompt with the message will be displayed to make it consistent with bug1039501

Comment 14

[Jenny Lee]

(In reply to Manuel Casas Barrado [:mancas] from comment #13)
> (In reply to Jenny Lee from comment #12)
> > Created attachment 8504008 [details]
> > no internet connection.png
> > 
> > Hi Manuel,
> > Not sure why but see attached for what I actually see when tap on system
> > update notification with no internet connection. I think the message shown
> > is proper in this case, but the download button is missing (note that this
> > dialog format is not defined in building blocks, but we can discuss that in
> > separate bug in the future). I would like to have it back in gray out form.
> > Let me know if this is a bug or something else. Thanks!
> 
> Hi Jenny, I'm not sure about the expected behaviour here since I've not
> implemented it and I don't know if we have specs for this part. Could you
> provide the specs needed to handle this situation?
> 
Unfortunately I won't be able to update the spec until later in the 2.2 development cycle.

> I suggest to remove this notification and when user tap in download, a
> prompt with the message will be displayed to make it consistent with
> bug1039501

I agree. Please do so for now and I can look into how to improve the UX here in later release, thanks for your help :)

Comment 15

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8502328 [details] [review]
Warning is not longer shown

Etienne, the patch has been modified according to the previous comments. Please take a look, and check if I've forgotten to remove anything about the old warnings.

Thanks!

Comment 16

[Manuel Casas Barrado [:mancas]]

Attachment: no-connection.png

Comment 17

[Manuel Casas Barrado [:mancas]]

Attachment: no-connection-warning.png

Comment 18

[Jenny Lee]

Comment on attachment 8507684 [details]
no-connection-warning.png

Looks good to me but still ni Matej for string review.

Hi Matej,
This string is for when user tries to download system update without internet connection. please take a look, thanks!

Comment 19

[Etienne Segonzac (:etienne)]

Comment on attachment 8502328 [details] [review]
Warning is not longer shown

Thanks!

Comment 20

[Matej Novak [:matej]]

(In reply to Jenny Lee from comment #18)
> Comment on attachment 8507684 [details]
> no-connection-warning.png
> 
> Looks good to me but still ni Matej for string review.
> 
> Hi Matej,
> This string is for when user tries to download system update without
> internet connection. please take a look, thanks!

Can we remove "Connection unavailable" and just keep the second line?

Comment 21

[Manuel Casas Barrado [:mancas]]

Attachment: no-connection-warning.png

Comment 22

[Matej Novak [:matej]]

That looks good to me. Everyone else OK with that?

Comment 23

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/f66b6e2f31a379cad208d28099d2f8fbaf042630

Comment 24

[Loli (:lolimartinezcr)]

Tested and working
flame
user
master
188based
Gecko-aefcebe
Gaia-7256858