1079241 - [Loop] contacts icon not centered in call log toolbar @1x

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: bug.png

In @1x pixel density image is not centered.
This does not reproduce in @1.5x phones like flame.

Comment 1

[Maria Angeles Oteo (:oteo)]

Arnau, can you check it also in FireE? Fire E and Flame have different resolutions so if in Fire E the icon is not centered we need to prioritize the bug as FireE is our target device.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Don't have a FireE, but I guess it will be ok there, as it has a larger pixel density.

Comment 3

[Maria Angeles Oteo (:oteo)]

I have tested the app in a Fire E device, and you are right there is no issue with that icon, it's centered in the middle of the call log.

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8502801 [details] [review]
patch in github

One comment in the PR. Please address it and check with UX before merging!

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/9a785b52fe92a0e848022c95637f5ada9800fd85