Closed Bug 1079251 Opened 5 years ago Closed 5 years ago
Omx YUVFormat To RGB565() does not care about gralloc buffer height in HAL _PIXEL _FORMAT _YV12 case
ConvertOmxYUVFormatToRGB565() does not care about gralloc buffer height. Therefore, if gralloc buffer size and valid size is different, it failed to to convert color correctly.
This seems to fix the problem.
The change of attachment 8501056 [details] [diff] [review] is going to be handled as part of bug 1075077.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1075077
It seems better to handle this bug as separate from Bug 1075077.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attachment #8501803 - Flags: review?(nical.bugzilla)
nical, can you review the patch soon?
Attachment #8501803 - Flags: review?(nical.bugzilla) → review+
Nominate to b2g-v2.0M+. This bug blocks b2g-v2.0M+ bug.
blocking-b2g: --- → 2.0M?
Hi Sotaro, Thanks for the nomination, I make it a 2.0M+
blocking-b2g: 2.0M? → 2.0M+
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Hi Norry, qawanted for Woodduck 2.0M. Thanks!
Hi Josh, No steps to reproduce,please add.
Does this need to land on v2.1 as well? Please nominate it if so :)
A patch for b2g v2.1. Carry "r=nical".
Attachment #8509458 - Flags: review+
Comment on attachment 8509458 [details] [diff] [review] patch for b2gv2.1 - fix CbCr buffer address NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: Some hardware's video thumbnail's color becomes incorrect. Testing completed: locally tested. Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none.
Attachment #8509458 - Flags: approval-mozilla-b2g34?
Attachment #8509458 - Flags: approval-mozilla-b2g34? → approval-mozilla-b2g34+
No steps to reproduce, unable to perform bug verification.
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-Verify-]
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-Verify-] → [QAnalyst-Triage+][QAnalyst-verify-]
You need to log in before you can comment on or make changes to this bug.