Closed Bug 1079278 Opened 5 years ago Closed 5 years ago

indexedDB xpcshell tests inadvertently disabled on android

Categories

(Core :: DOM: IndexedDB, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 994190 renamed dom/indexedDB/test/unit/xpcshell.ini to dom/indexedDB/test/unit/xpcshell-shared.ini but unfortunately forgot to update the root android manifest in the process:
http://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/xpcshell_android.ini

Horribly enough, the harness spit out a warning, but nothing that turned the job orange, so this went unnoticed. In bug 1066735 I'm working to remove the android and b2g specific xpcshell manifests so this doesn't happen again in the future.
Hopefully nothing broke in the meantime:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a2f300ef2832
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
That was wishful thinking:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2299119&repo=try

Ben, I'll leave it up to you whether you want to fix or disable this test.
Assignee: ahalberstadt → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(bent.mozilla)
Let's just disable that one test, it's somehow related to the way we do packaging on android and I don't have time to look at it right now.
Flags: needinfo?(bent.mozilla)
Also disables test_globalObjects_other.js on android.
Assignee: nobody → ahalberstadt
Attachment #8501766 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8501904 - Flags: review?(bent.mozilla)
Comment on attachment 8501904 [details] [diff] [review]
Re-enable indexedDB xpcshell tests on Android

Review of attachment 8501904 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8501904 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/50a379edc315
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.