1079314 - In non-debug builds, logical-coordinate classes should not have an mWritingMode member at all

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Kew [:jfkthame]]

The intended design of the logical-coordinate geometry classes in WritingModes.h was that the mWritingMode field should only be present in debug builds, for validation by CHECK_WRITING_MODE, but in non-debug builds we'd avoid the overhead of tagging these classes with the mode.

However, the mWritingMode field was inadvertently not guarded by #ifdef DEBUG, and so it is present in all builds, even though we don't actually set it in non-debug builds.

And then we've got a couple of places where non-debug code actually refers to the mWritingMode field, which it should never do. In the LogicalSize [in]equality operators, we can't make equality depend on comparing the writing modes of the operands; rather, we need to mandate that these operators (like others) are only valid when writing modes match.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Remove the mWritingMode field from logical-coordinate objects in non-debug builds.

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b818ba8aabc2

Comment 3

[Carsten Book [:Tomcat]]

sorry had to back this out in :

https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=32c4d5043b18

since one of this changes caused https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2845533&repo=mozilla-inbound

Comment 4

[Jonathan Kew [:jfkthame]]

This passed try yesterday:
https://tbpl.mozilla.org/?tree=Try&rev=91e2d584ad04

So I've relanded it by itself:
https://hg.mozilla.org/integration/mozilla-inbound/rev/681c4450639e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/681c4450639e