Closed Bug 1079372 Opened 5 years ago Closed 5 years ago

Make the default browser notification bar yellow

Categories

(Firefox :: General, defect)

defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 35
Iteration:
35.3
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 --- verified
firefox35 --- verified

People

(Reporter: phlsa, Assigned: dao)

References

Details

Attachments

(2 files)

The notification bar we use now to ask users to set Firefox as their default browser is currently black. Since this is a pretty important prompt, we should make it more prominent.
The original design specified yellow as the background color, so let's do that.
Flags: firefox-backlog+
Why spend time doing this rather than bug 1025182?
Flags: needinfo?(philipp)
(In reply to :Gijs Kruitbosch from comment #1)
> Why spend time doing this rather than bug 1025182?

I was under the impression that bug 1025182 was a general update of the appearance of all notification bars.
This is more of a hotfix to make that specific bar more prominent. There are some concerns about the bar hurting our default browser numbers (that concerns currently have no basis in data), but if they do turn out to be correct, it would be good to have something that we can uplift (hence only changing the color, not the styling).
Flags: needinfo?(philipp)
Flags: qe-verify?
Component: Toolbars and Customization → General
Blocks: 951627
Flags: qe-verify? → qe-verify+
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8501288 - Flags: review?(mano)
Iteration: --- → 35.3
Points: --- → 1
Hardware: x86 → All
Comment on attachment 8501288 [details] [diff] [review]
patch

Review of attachment 8501288 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, rs=me
Attachment #8501288 - Flags: review?(mano) → review+
https://hg.mozilla.org/mozilla-central/rev/75046b047a6c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
QA Contact: camelia.badau
Attached image issue.png
Verified on latest Nightly 35.0a1 (buildID: 20141009030201):
- on Windows 7 64bit, Mac OSX 10.9.5 and Mac OSX 10.10 -> the default browser notification bar is yellow
- on Ubuntu 13.10 32bit and Ubuntu 13.04 64bit -> the default browser notification bar is BLACK. Please see attached screenshot "issue.png".
Flags: needinfo?(dao)
(In reply to Camelia Badau, QA [:cbadau] from comment #7)
> Created attachment 8503089 [details]
> issue.png
> 
> Verified on latest Nightly 35.0a1 (buildID: 20141009030201):
> - on Windows 7 64bit, Mac OSX 10.9.5 and Mac OSX 10.10 -> the default
> browser notification bar is yellow
> - on Ubuntu 13.10 32bit and Ubuntu 13.04 64bit -> the default browser
> notification bar is BLACK. Please see attached screenshot "issue.png".

This is expected, as the notification bar uses the InfoBackground color on Windows and Linux, which will be yellow with most OS themes but can also resolve to a different color.

On Ubuntu this patch made us go from gray to black; the latter stands out more than the former.
Flags: needinfo?(dao)
Thank you!
Status: RESOLVED → VERIFIED
Comment on attachment 8501288 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 951627
[User impact if declined]: less prominent default browser notification bar
[Describe test coverage new/current, TBPL]: none
[Risks and why]: one-liner, not risky
[String/UUID change made/needed]: none
Attachment #8501288 - Flags: approval-mozilla-aurora?
Comment on attachment 8501288 [details] [diff] [review]
patch

Aurora+

Dão - We have no sheriff coverage this weekend. Can you land this on Aurora before the merge on Monday?
Attachment #8501288 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(dao)
Verified on latest Aurora 34 (BuildID=20141013004002) with same results as in comment 7: yellow notification on Win 7 x64 and Mac OS X 10.9.5, black notification on Ubuntu 13.04 x64.
You need to log in before you can comment on or make changes to this bug.