1079411 - Update FMD launcher to use SettingsListener.observe

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We currently manually check the 'findmydevice.enabled' setting, then wire up a separate observer.

Simplify the code by switching to `SettingsListener.observe('findmydevice.enabled', false, cb)`.

This was suggested in the review for bug 1062558, but I'm putting it off to try to land the fix more quickly, and change as little as possible in the existing code.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Per bug 1062558, this is the v2.2/v3.0 fix for a bug that's marked a v2.1 blocker.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I don't have time for this, and I am not currently working on Gaia stuff, can anyone else take this?

Comment 3

[:gerard-majax]

I don't either, and I fear we regress bug 1105639, because .observe() will add a new observer each time ...

Comment 4

[Stephany Wilkes]

In B2G triage and triage is blocking based on FMD UX being high priority for 2.2; possible regressing of other bugs; and 2.1+ history.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

I don't have time either. This seems not a blocker to me as it is only code refinement and has nothing to do with the UX.

Comment 6

[Kai-Chih Hu [:khu]]

Tarek, is it something that your team is working on? Thank you.

Comment 7

[Kai-Chih Hu [:khu]]

Hi, Ian, is it something that you can help? Thanks.

Comment 8

[Ian Bicking (:ianbicking)]

See response in bug 1124335, comment 7

Comment 9

[Bobby Chien]

Guilherme, could you help on this?

Comment 10

[Guilherme Gonçalves [:ggp]]

This bug got filed during the review process for bug 1062558 to track a simple refactoring change to be made to FMD's launcher in the system app. That code has changed quite a bit since then, and that refactoring is no longer straightforward in v2.2

However, the problem addressed in bug 1062558 should still be present in v2.2, and I see comments in bug 1062558 suggesting that we use this bug to fix v2.2. I personally think we should file a separate bug for that, but leave this one open for now as it may make sense to use SettingsListener after we've solved the new one.

Either way, I don't think I'll be able to work on this, sorry. I've only been involved with Mozilla as a volunteer for a few months now, and this will take more time than I'm capable of sparing these days.

Comment 11

[howie [:howie]]

Hi Alexandre, do you have time for this now? Thanks.

Comment 12

[:gerard-majax]

I don't have time.

Comment 13

[Kai-Chih Hu [:khu]]

(In reply to Stephany Wilkes from comment #4)
> In B2G triage and triage is blocking based on FMD UX being high priority for
> 2.2; possible regressing of other bugs; and 2.1+ history.

Sorry. Could you remind us which item[1] this bug blocks to? 
[1] https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to Kevin Hu [:khu] from comment #13)
> (In reply to Stephany Wilkes from comment #4)
> > In B2G triage and triage is blocking based on FMD UX being high priority for
> > 2.2; possible regressing of other bugs; and 2.1+ history.
> 
> Sorry. Could you remind us which item[1] this bug blocks to? 
> [1] https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block

does not look like a new regression and currently blocks a refactoring bug. Steph, not sure if I am missing to consider anything for this to block on 2.2 at this time. Feel free to NI me in that case, for now I am removing the nom here.

Comment 15

[No-Jun Park [:njpark]]

[Tracking Requested - why for this release]:

Seems like no one is available to fix FMD bug in general, putting it to the b2g-tracking backlog

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

WONTFIX-ing my fxos bugs