1079544 - Modify Firefox download button helper to include "Update Firefox" button text variation

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Chris More [:cmore]]

We now have a new simple=true variation of the download button that can be activated on any www.mozilla.org page. The simplified button says "Free Download". The "Free Download" CTA is more relevant for non-Firefox users, but for Firefox users that are out-of-date, the CTA is not very compelling. It is even more compelling to use "Update Firefox" on pages that have conditional content specific to out-of-date Firefox users. Pages like /firefox/new/, homepage, and /plugincheck/ would benefit from this change.

We need to check with L10N to see if this string is already localized and how much time it would take to get this localized.

Comment 1

[Pascal Chevrel:pascalc]

We don't have 'Update Firefox', we have 'Update your Firefox' in 39 locales though (used in the Sync page for a download button)

Comment 2

[Chris More [:cmore]]

(In reply to Pascal Chevrel:pascalc from comment #1)
> We don't have 'Update Firefox', we have 'Update your Firefox' in 39 locales
> though (used in the Sync page for a download button)

That could work and is even more explicit.

Comment 3

[Chris More [:cmore]]

Attachment: Out-of-date button on /firefox/new/

Comment 4

[Chris More [:cmore]]

Attachment: Out-of-date button on /plugincheck/

Comment 5

[Chris More [:cmore]]

Given that "Update Your Firefox" is more strings than "Free Download", I had to do a CSS padding change to put it on one line for en-US, but it may wrap for other locales with long words regardless. i.e. German.

Comment 6

[Francesco Lodolo [:flod]]

Note: before we're going to use this, we'll need to move the string to a shared file like main.lang

I think there were discussions about having also a "Download Firefox" as a shared string.

Comment 7

[Pascal Chevrel:pascalc]

download_button.lang seems like the right file to store this string :) 
'Download Firefox' is already a shared string in download_button.lang:
http://www.langchecker.org/?website=0&file=download_button.lang&action=translate

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Pascal Chevrel:pascalc from comment #7)
> download_button.lang seems like the right file to store this string :)

I agree, simply wasn't sure that download_button.lang is loaded by all templates.

Comment 9

[Pascal Chevrel:pascalc]

(In reply to Francesco Lodolo [:flod] from comment #8)
> (In reply to Pascal Chevrel:pascalc from comment #7)
> > download_button.lang seems like the right file to store this string :)
> 
> I agree, simply wasn't sure that download_button.lang is loaded by all
> templates.

It is 
https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L48

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Pascal Chevrel:pascalc from comment #9)
> It is 
> https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L48

Thanks, you saved me a search :-)

I thought we could associate lang files only through templates, but never met main.lang anywhere, so it had to be somewhere else, but never actually checked.

Comment 11

[Chris More [:cmore]]

This bug will be more effective and would have a better UX if bug 998962 was also resolved.

Comment 12

[Jonathan Petto [:jpetto]]

Should this change be opt-in (starting with the pages mentioned in comment #0), or should every instance of the download button detect if the user is on an old version of Firefox and change the text to 'Update your Firefox'?

Comment 13

[Chris More [:cmore]]

(In reply to Jon Petto [:jpetto] from comment #12)
> Should this change be opt-in (starting with the pages mentioned in comment
> #0), or should every instance of the download button detect if the user is
> on an old version of Firefox and change the text to 'Update your Firefox'?

Hmmm, habber and I discussed it. The concern is that this updated text would work much better with bug 998962. Maybe we should make this opt-in on a page-by-page basis and decide where to roll it out first. Probably /plugincheck/ for now.

Comment 14

[Holly Habstritt Gaal [:Habber]]

(In reply to Chris More [:cmore] from comment #13)
> (In reply to Jon Petto [:jpetto] from comment #12)
> > Should this change be opt-in (starting with the pages mentioned in comment
> > #0), or should every instance of the download button detect if the user is
> > on an old version of Firefox and change the text to 'Update your Firefox'?
> 
> Hmmm, habber and I discussed it. The concern is that this updated text would
> work much better with bug 998962. Maybe we should make this opt-in on a
> page-by-page basis and decide where to roll it out first. Probably
> /plugincheck/ for now.

+1 to opting in on a page by page basis until we have the functionality presented in bug 998962. "Update" is a bit misleading to present on a button if it is triggering a download as opposed to updating your current browser.

Comment 15

[Jonathan Petto [:jpetto]]

Attachment: GitHub Pull Request

Comment 16

[Francesco Lodolo [:flod]]

Is the string "Update your Firefox" confirmed as final? I have a couple of strings to push to all locales (main.lang, tabzilla.lang), so it would be nice to push them all together.

Comment 17

[Chris More [:cmore]]

(In reply to Francesco Lodolo [:flod] from comment #16)
> Is the string "Update your Firefox" confirmed as final? I have a couple of
> strings to push to all locales (main.lang, tabzilla.lang), so it would be
> nice to push them all together.

Confirmed. Thanks!

Comment 18

[Jonathan Petto [:jpetto]]

Should (outdated) Firefox for Android receive the new string as well, or be excluded from this check? I'm guessing the former, but want to confirm.

Comment 19

[Chris More [:cmore]]

(In reply to Jon Petto [:jpetto] from comment #18)
> Should (outdated) Firefox for Android receive the new string as well, or be
> excluded from this check? I'm guessing the former, but want to confirm.

It doesn't hurt to include outdated Android as they can go to the play store and update their Firefox. The play store does change their buttons from "install" to "update" when there is a newer version too.

Comment 20

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/91c4cbff741bef0d717e51ee8255362caab93164
Add text variation to fx dl button. Bug 1079544.

https://github.com/mozilla/bedrock/commit/5e63f7aa6dd2bc6aa1aeb6cfd32b53c493090384
Merge pull request #2387 from jpetto/bug-1079544-dl-button-text-variation

Add text variation to fx dl button. Bug 1079544.

Comment 21

[Jonathan Petto [:jpetto]]

This is now in production and working on https://www.mozilla.org/en-US/plugincheck/. Marking as verified/fixed.