Closed Bug 1079565 Opened 5 years ago Closed 5 years ago

Remove prefix from -moz-calc usage in /mobile

Categories

(Firefox for Android :: General, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: Margaret, Assigned: lviknesh, Mentored)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

I accidentally just added more of this when I landed my patch for bug 1075219, but there are already places in the tree we need to update:

http://mxr.mozilla.org/mozilla-central/search?find=/mobile/android/&string=-moz-calc%28

We should just replace -moz-calc() with calc().
Hey,
I am new here, can you assign this bug to me. Any supporting documents or links will be helpful.
Cheers,
Swanand.
Attached patch calc.patchSplinter Review
Assignee: nobody → lviknesh
Status: NEW → ASSIGNED
Attachment #8502601 - Flags: review?(margaret.leibovic)
(In reply to Swanand from comment #1)
> Hey,
> I am new here, can you assign this bug to me. Any supporting documents or
> links will be helpful.
> Cheers,
> Swanand.

It looks like vikneshwar already beat you to this bug! But for future bugs, you can check out our "Get Involved" page here: 
https://wiki.mozilla.org/Mobile/Get_Involved
Comment on attachment 8502601 [details] [diff] [review]
calc.patch

Review of attachment 8502601 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks for the quick fix.
Attachment #8502601 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/1b8a149b1cf7
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1b8a149b1cf7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.