1079621 - Intermittent test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range (ASSERTION: Couldn't pass frame to decoder: 'Error', file content/media/fmp4/apple/AppleVTDecoder.cpp, line 243)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=48649907&tree=Mozilla-Central

Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test mochitest-2 on 2014-09-22 21:08:12 PDT for push 603dad513d7c
slave: talos-mtnlion-r5-023

21:25:29     INFO -  [Parent 1291] WARNING: VideoToolbox decoder returned no data: file /builds/slave/m-cen-osx64-d-0000000000000000/build/content/media/fmp4/apple/AppleVTDecoder.cpp, line 165
21:25:29     INFO -  [Parent 1291] ###!!! ASSERTION: Couldn't pass frame to decoder: 'Error', file /builds/slave/m-cen-osx64-d-0000000000000000/build/content/media/fmp4/apple/AppleVTDecoder.cpp, line 243
21:25:30     INFO -  JavaScript error: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightlyDebug.app/Contents/MacOS/omni.ja!/components/nsHandlerService.js, line 891: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
21:25:45     INFO -  JavaScript error: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightlyDebug.app/Contents/MacOS/omni.ja!/components/nsHandlerService.js, line 891: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
21:25:56     INFO -  nsRunnableMethodImpl<tag_nsresult (mozilla::AppleVTDecoder::*)(mp4_demuxer::MP4Sample*), nsAutoPtr<mp4_demuxer::MP4Sample>, true>::Run() [xpcom/glue/nsThreadUtils.h:363]
21:25:56     INFO -  mozilla::MediaTaskQueue::Runner::Run() [mfbt/RefPtr.h:301]
21:25:56     INFO -  nsThreadPool::Run() [xpcom/glue/nsCOMPtr.h:520]
21:25:56     INFO -  _ZThn8_N12nsThreadPool3RunEv [obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads0.cpp:234]
21:25:56     INFO -  nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:823]
21:25:56     INFO -  NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:265]
21:25:56     INFO -  mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:339]
21:25:56     INFO -  MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:509]
21:25:56     INFO -  nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:359]
21:25:57     INFO -  _pt_root [nsprpub/pr/src/pthreads/ptthread.c:215]
21:25:57     INFO -  libsystem_c.dylib + 0x14782
21:25:57     INFO -  OpenGL version detected: 210
21:25:57     INFO -  OpenGL vendor: Intel Inc.
21:25:57     INFO -  OpenGL renderer: Intel HD Graphics 3000 OpenGL Engine
21:25:57     INFO -  [Parent 1291] WARNING: We can't support non-premultiplied alpha for video!: '(aSurfaceFlags & SFE_PREFER_NO_PREMULTIPLY_ALPHA) == 0', file /builds/slave/m-cen-osx64-d-0000000000000000/build/layout/base/nsLayoutUtils.cpp, line 5901
21:25:57     INFO -  [Parent 1291] WARNING: We can't support non-premultiplied alpha for video!: '(aSurfaceFlags & SFE_PREFER_NO_PREMULTIPLY_ALPHA) == 0', file /builds/slave/m-cen-osx64-d-0000000000000000/build/layout/base/nsLayoutUtils.cpp, line 5901
21:25:57     INFO -  [Parent 1291] WARNING: We can't support non-premultiplied alpha for video!: '(aSurfaceFlags & SFE_PREFER_NO_PREMULTIPLY_ALPHA) == 0', file /builds/slave/m-cen-osx64-d-0000000000000000/build/layout/base/nsLayoutUtils.cpp, line 5901
21:25:57     INFO -  [Parent 1291] WARNING: We can't support non-premultiplied alpha for video!: '(aSurfaceFlags & SFE_PREFER_NO_PREMULTIPLY_ALPHA) == 0', file /builds/slave/m-cen-osx64-d-0000000000000000/build/layout/base/nsLayoutUtils.cpp, line 5901
21:25:57     INFO -  1040 INFO TEST-OK | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | took 8638ms
21:25:57     INFO -  [Parent 1291] WARNING: Failed to unlock the wakelock.: '!rv.Failed()', file /builds/slave/m-cen-osx64-d-0000000000000000/build/content/html/content/src/HTMLVideoElement.cpp, line 245
21:25:57     INFO -  ++DOMWINDOW == 32 (0x125db4c00) [pid = 1291] [serial = 2682] [outer = 0x124483400]
21:25:57     INFO -  1041 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 1

[Jean-Yves Avenard [:jya]]

should I still apply this fix for the 34/beta branch ?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Sure :)

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Return error instead of asserting

Backported for 34 branch

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8504431 [details] [diff] [review]
Return error instead of asserting

Approval Request Comment
[Feature/regressing bug #]:1043696
[User impact if declined]:will fail mochitest and may cause crashes
[Describe test coverage new/current, TBPL]:code has been in use in nightly for a month
[Risks and why]: can't foresee any.
[String/UUID change made/needed]: none

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8504431 [details] [diff] [review]
Return error instead of asserting

Beta+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9be2b1620955

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Wait a sec, this was the spinoff from bug 1069005. The beta patch here was for that one, no?

Comment 8

[Jean-Yves Avenard [:jya]]

the patch here is for beta (well, it was for aurora, but that one became beta in the mean time)...

bug 1069005 was for nightly, but it got fixed as a side effect of resolving bug 1066369, which couldn't be applied without rewrite on aurora (now beta)

Hope that makes sense...

So it's all good :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

But the patch here fixed the "Couldn't pass frame to decoder: 'rv == noErr'" assert bug 1066369 was filed for, not the "Couldn't pass frame to decoder: 'Error'" assert (on trunk no less) that this was spun off for.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

s/1066369/1069005

Comment 11

[Jean-Yves Avenard [:jya]]

I see.

They are both fixed with this patch... 3 potential assertions were removed...

Why it asserted may have been for different reasons, but the end result was the same: it was a simple error and should have been treated as such.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

It's confusing because bug 1069005 comment 3 (what this bug was filed for) happened on trunk after bug 1066369 landed.

Comment 13

[Jean-Yves Avenard [:jya]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> It's confusing because bug 1069005 comment 3 (what this bug was filed for)
> happened on trunk after bug 1066369 landed.

I'm tracking the revision on that file.

I don't even see what could could have ever created that assertion... 

unless NS_ERROR cause an assertion as far as the test bot are concerned. Ah yes it does in debug mode...

Then yes, you're right, that patch applies to bug 1066369 and that should still be uplifted to beta IMHO...

Why the Apple decoder fails at random from time to time is still unexplained... but the error is usually recovered after the next packet and isn't a problem per say... not much we can do about it

Comment 14

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-10-24T07:55:36
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=3287371
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: talos-mtnlion-r5-071
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-2
revision: e94b66dca22c

1045 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.
2147 INFO TEST-UNEXPECTED-ERROR | /tests/dom/indexedDB/test/test_filehandle_readonly_exceptions.html | Assertion count 4 is greater than expected range 0-0 assertions.

Comment 15

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-10-28T00:33:24
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=3346888
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-snow-r4-0117
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-1
revision: ac5e69c40ff1

2229 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 16

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-10-28T00:57:23
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=3348207
repository: mozilla-inbound
who: tomcat[at]mozilla[dot]com
machine: t-snow-r4-0142
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-1
revision: 8d4d7a689070

109 INFO TEST-UNEXPECTED-FAIL | /tests/docshell/test/test_bug511449.html | Cmd+W should have closed the tab - expected PASS
2231 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 17

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-03T08:31:22
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-b2g34_v2_1&job_id=24372
repository: mozilla-b2g34_v2_1
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-054
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-b2g34_v2_1 debug test mochitest-2
revision: 1eb9dbd7aacd

1043 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 18

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-11-05T12:27:20
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-central&job_id=589693
repository: mozilla-central
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-069
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test mochitest-gl
revision: 305b4fecce99

621 INFO TEST-UNEXPECTED-ERROR | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__tex-image-and-sub-image-2d-with-video.html | Assertion count 1 is greater than expected range 0-0 assertions.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

I think there's enough hits here to prove the point now that this is still an ongoing issue independent of bug 1066369.

Comment 20

[Jean-Yves Avenard [:jya]]

Attachment: Change non-fatal errors to warnings, fatal ones to errors

Make non-fatal errors warnings only.

Comment 21

[Ralph Giles (:rillian)]

Comment on attachment 8517783 [details] [diff] [review]
Change non-fatal errors to warnings, fatal ones to errors

Review of attachment 8517783 [details] [diff] [review]:
-----------------------------------------------------------------

The theory is that NS_ERROR() triggers an assertion in debug builds, which tinderbox reports as a failure. NS_WARNING calls NS_DebugBreak, but the lower severity skips invoking the debugger. Please put that in the body of your commit message and fix the summary. The whole point of the patch is to _not_ make the fatal ones errors.

I still have reservations about papering over the issue like this, but I suppose it's better to fix the intermittent test failures. r=me with the commit message fixed.

Comment 22

[Ralph Giles (:rillian)]

Commit message should be like:

Bug 1079621: Change non-fatal errors to warnings. r=rillian

This resolves intermittent failures in continuous integration.

NS_ERROR() triggers an assertion in debug builds, which tinderbox
reports as a failure. NS_WARNING calls NS_DebugBreak, but with the
lower severity level it skips invoking the debugger.

Comment 23

[Jean-Yves Avenard [:jya]]

Attachment: Change non-fatal errors to warnings

Carrying r+

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70d8f09b2e17

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70d8f09b2e17

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70d8f09b2e17

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Can we land this on Aurora/Beta please? Seems pretty low-risk :)

Comment 28

[Jean-Yves Avenard [:jya]]

Attachment: Aurora: Change non-fatal errors to warnings

Aurora patch

Comment 29

[Jean-Yves Avenard [:jya]]

Attachment: Aurora: Change non-fatal errors to warnings

rename patch file. Simple backport to already r+ patch

Comment 30

[Jean-Yves Avenard [:jya]]

Attachment: Beta: Change non-fatal errors to warnings

Backport for beta

Comment 31

[Jean-Yves Avenard [:jya]]

Comment on attachment 8521077 [details] [diff] [review]
Aurora: Change non-fatal errors to warnings

Approval Request Comment
[Feature/regressing bug #]:1043696
[User impact if declined]:will fail mochitest and may cause crashes
[Describe test coverage new/current, TBPL]:code has been in use in nightly for a month
[Risks and why]: can't foresee any.
[String/UUID change made/needed]: none

Comment 32

[Jean-Yves Avenard [:jya]]

Comment on attachment 8521082 [details] [diff] [review]
Beta: Change non-fatal errors to warnings

Approval Request Comment
[Feature/regressing bug #]:1043696
[User impact if declined]:will fail mochitest and may cause crashes
[Describe test coverage new/current, TBPL]:code has been in use in nightly for a month
[Risks and why]: can't foresee any.
[String/UUID change made/needed]: none

Comment 33

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8521082 [details] [diff] [review]
Beta: Change non-fatal errors to warnings

Beta's crash rate is in a good range for release. Without knowing that this causes frequent or serious crashes I suggest that even though this is a simple change that we ship it in 35. Please renom if you really think this fix should ship in 34.

Comment 34

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d9008e8bed6