Closed Bug 1079640 Opened 5 years ago Closed 5 years ago

Various tests added by bug 1066432 are going to perma-fail when Gecko 35 merges to Aurora

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox34 --- unaffected
firefox35 --- verified

People

(Reporter: RyanVM, Assigned: jorendorff)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:
Multiple perma-oranges after the uplift.

The uplift is on Monday, so these need addressing ASAP.

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2283291&repo=try
builder 	Ubuntu VM 12.04 try debug test cppunit

18:41:20 INFO - testForOfIterator_bug515273_part2
18:41:20 INFO - TEST-PASS | testForOfIterator_bug515273_part2 | ok
18:41:20 INFO - testForOfIterator_bug515273_part1
18:41:20 WARNING - TEST-UNEXPECTED-FAIL | testForOfIterator_bug515273_part1 | var obj = { '@@iterator': 5, [Symbol.iterator]: Array.prototype[Symbol.iterator] }; obj;
18:41:20 INFO - testForOfIterator_basicNonIterable
18:41:20 WARNING - TEST-UNEXPECTED-FAIL | testForOfIterator_basicNonIterable | var obj = { '@@iterator': 5, [Symbol.iterator]: Array.prototype[Symbol.iterator] }; obj; 


https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2283306&repo=try
builder 	Ubuntu VM 12.04 try debug test mochitest-2

18:36:30 INFO - 67 INFO TEST-START | /tests/dom/bindings/test/test_sequence_detection.html
18:36:30 INFO - ++DOMWINDOW == 62 (0x9b254bb0) [pid = 1826] [serial = 100] [outer = 0x9b251b40]
18:36:30 INFO - 68 INFO TEST-PASS | /tests/dom/bindings/test/test_sequence_detection.html | got a TestInterfaceJS object
18:36:30 INFO - 69 INFO TEST-UNEXPECTED-FAIL | /tests/dom/bindings/test/test_sequence_detection.html | Should get a TypeError for the overload case - got ReferenceError, strictly expected TypeError
18:36:30 INFO - 70 INFO TEST-UNEXPECTED-FAIL | /tests/dom/bindings/test/test_sequence_detection.html | Should have a message about being non-iterable in the overload case - expected PASS
18:36:30 INFO - 71 INFO TEST-UNEXPECTED-FAIL | /tests/dom/bindings/test/test_sequence_detection.html | Should get a TypeError for the union case - got ReferenceError, strictly expected TypeError
18:36:30 INFO - 72 INFO TEST-UNEXPECTED-FAIL | /tests/dom/bindings/test/test_sequence_detection.html | Should have a message about being non-iterable in the union case - expected PASS
18:36:30 INFO - 73 INFO TEST-OK | /tests/dom/bindings/test/test_sequence_detection.html | took 198ms
Flags: needinfo?(bzbarsky)
Hrm.  This is fundamentally the same thing as bug 1073853.

Jason, are we planning to land bug 918828 before the uplift?  If not, do you have a preferred way I should change the tests here?
Flags: needinfo?(bzbarsky)
Assignee: nobody → jorendorff
(In reply to Boris Zbarsky [:bz] from comment #1)
> Jason, are we planning to land bug 918828 before the uplift?  If not, do you
> have a preferred way I should change the tests here?

Even if I could guarantee it's going to land, enabling symbols by default is an independent choice -- just in case we need to turn it off before release, the tests need to work either way. They should check whether 'typeof Symbol === "function"'. I'm changing them now.
Comment on attachment 8501830 [details] [diff] [review]
Fix some tests that fail when symbols are not defined

r=me.  Thank you for picking this up!
Attachment #8501830 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/50288676ddbc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.