Make diffs more useful by sorting first

RESOLVED FIXED

Status

Release Engineering
Balrog: Frontend
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

json stored in python dicts is not so great for consistent ordering, which makes diffs noisy.
Created attachment 8501498 [details] [diff] [review]
[balrog] Sort the keys

This gets me a diff of
      "partials": {
        "Firefox-31.0-build2": "firefox-31.0-33.0.partial.mar", 
        "Firefox-32.0.2-build1": "firefox-32.0.2-33.0.partial.mar", 
-       "Firefox-32.0.3-build1": "firefox-32.0.3-33.0.partial.mar"
+       "Firefox-32.0.3-build1": "firefox-32.0.3-33.0.partial.mar", 
?                                                                 ++

+       "Firefox-33.0b9-build1": "firefox-33.0b9-33.0.partial.mar"
      }
    }, 
for fixing up the Firefox 33.0 blob (see https://wiki.mozilla.org/Releases/Firefox_33.0/BuildNotes#Updates_for_beta). It's still a little strange, but doesn't have any spurious changes in it for appVersion.
Attachment #8501498 - Flags: review?(bhearsum)
Attachment #8501498 - Flags: review?(bhearsum) → review+

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d380eb2bd6d9bed46fd1247282703112be6173d3
Bug 1079641, make diffs more useful by sorting first, r=bhearsum
Waiting for the next push to production. No great rush.
Depends on: 1086565
I think this is in production now?
Oh yes, thanks for the reminder.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.