1079651 - Enable strict mode when parsing xpcshell manifests

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Andrew Halberstadt [:ahal]]

When parsing manifests xpcshell sets strict=False:
http://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#793

Once bug 1066735 lands we should flip this to True to avoid missing non-existing manifests and tests in the future.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: enable_strict_manifests

Let's see what happens:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=14c6127866dd

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8501757 [details] [diff] [review]
enable_strict_manifests

Review of attachment 8501757 [details] [diff] [review]:
-----------------------------------------------------------------

I ran across bug 970455 that made me a little nervous, but I wasn't able to reproduce the issue with this patch applied.

Looking at what it's used for I'd vote for deprecating strict mode altogether.

Comment 3

[Andrew Halberstadt [:ahal]]

Yeah, I'd be ok with removing it. It is set to True by default at least.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7037d68868eb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/02279066be65

Comment 5

[(not currently active) Ted Mielczarek]

I don't honestly know why we have non-strict mode. Transitional concerns, maybe?

Comment 6

[Andrew Halberstadt [:ahal]]

I think it was an attempt to solve a problem we didn't yet have.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7037d68868eb