Closed Bug 1079651 Opened 5 years ago Closed 5 years ago

Enable strict mode when parsing xpcshell manifests

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set

Tracking

(firefox34 fixed, firefox35 fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

When parsing manifests xpcshell sets strict=False:
http://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#793

Once bug 1066735 lands we should flip this to True to avoid missing non-existing manifests and tests in the future.
Attachment #8501757 - Flags: review?(cmanchester)
Comment on attachment 8501757 [details] [diff] [review]
enable_strict_manifests

Review of attachment 8501757 [details] [diff] [review]:
-----------------------------------------------------------------

I ran across bug 970455 that made me a little nervous, but I wasn't able to reproduce the issue with this patch applied.

Looking at what it's used for I'd vote for deprecating strict mode altogether.
Attachment #8501757 - Flags: review?(cmanchester) → review+
Yeah, I'd be ok with removing it. It is set to True by default at least.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7037d68868eb
I don't honestly know why we have non-strict mode. Transitional concerns, maybe?
I think it was an attempt to solve a problem we didn't yet have.
https://hg.mozilla.org/mozilla-central/rev/7037d68868eb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.