Closed Bug 1079660 Opened 5 years ago Closed 5 years ago

DMD: don't call malloc et al. directly in the test

Categories

(Core :: DMD, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

From bug 1076446 comment 3:

> you're not supposed to call malloc from a replace malloc
> library. You're just lucky that it happens to work on linux and mac
> because of how things are, but that wouldn't work on android or
> windows.

So let's call replace_malloc et al. instead from DMD's tests. (And bug 1077361
is open for testing that replace_malloc itself is being called appropriately
when malloc is called.)
Simple.
Attachment #8501509 - Flags: review?(mh+mozilla)
Attachment #8501509 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b820349b5b46
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.