1079719 - Replace "greyscale" SVG filter with filter: grayscale(1)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dão Gottwald [:dao]]

about:addons uses a custom "greyscale" SVG filter:

> filter: url("chrome://mozapps/skin/extensions/extensions.svg#greyscale");

We should replace this with:

> filter: grayscale(1);

Files that need to be updated: http://mxr.mozilla.org/mozilla-central/search?string=greyscale&find=%2Fmozapps%2Fextensions%2F

Comment 1

[David Nelson]

Hi

Could you assign me this bug please?

Thanks,
David

Comment 2

[Ekanan Ketunuti]

(In reply to Dão Gottwald [:dao] from comment #0)
> We should replace this with:
> 
> > filter: grayscale(1);
> 


and also remove extensions.svg file ?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Ekanan Ketunuti from comment #2)
> (In reply to Dão Gottwald [:dao] from comment #0)
> > We should replace this with:
> > 
> > > filter: grayscale(1);
> > 
> 
> 
> and also remove extensions.svg file ?

yes

Comment 4

[Kapil Singh [:kapy]]

Attachment: Replace greyscale SVG filter with grayscale(1)

I have replaced the custom "greyscale" SVG filter with grayscale(1) in all the files you mentioned and deleted the extensions.svg files.
Can you please review my patch.
Although I am not assigned the bug, will my patch merge to the main code.

Thanks in advance,
Kapil

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8504866 [details] [diff] [review]
Replace greyscale SVG filter with grayscale(1)

You also need to remove extensions.svg from jar.mn files, otherwise the build will fail:

http://mxr.mozilla.org/mozilla-central/search?string=extensions.svg&find=jar.mn

Looks good otherwise!

Comment 6

[Kapil Singh [:kapy]]

Attachment: Replace greyscale SVG filter with grayscale(1)

Ok, I have removed extensions.svg from jar.mn files.
Please check the attachments.

Thanks,
Kapil

Comment 7

[Kapil Singh [:kapy]]

Attachment: Replace greyscale SVG filter with grayscale(1)

Sorry, I forgot to delete extensions.svg file from extensions folder, so don't check the previous attachment.
Check this one please.

Thanks

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8505965 [details] [diff] [review]
Replace greyscale SVG filter with grayscale(1)

Looks good, thanks!

Comment 9

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/3c8b7fa1a158

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c8b7fa1a158

Comment 11

[David Nelson]

Hi,

I'm just wondering, for future reference, is there much use in people being assigned bugs if another person comes along and fixes it?

I'm doing this as part of a module at Coventry University in the UK, so just querying for future use.

Thanks,
David

Comment 12

[Robert Longson [:longsonr]]

We do much prefer it if people don't do that. You really should ask in the bug to find out if the assignee has abandoned the bug and give them a chance to respond if not.

Having said that Kapil is new too and doesn't know the etiquette yet so once he does post a patch as the first thing he does we're left in a difficult position.

Please don't be too discouraged, this doesn't happen often and if you want to work on some other similar bugs Dao and I can suggest some.

Comment 13

[David Nelson]

Thanks Robert for the response, much appreciated. I'm looking through some bugs at the moment - will get back to you if I struggle to find any others!

Comment 14

[Kapil Singh [:kapy]]

Thanks Robert for the support, David with all the good intentions since there was no activity on the bug for a week I safely assumed it was okay to work on it. 
Anyway, henceforth I will make sure that I follow the correct norms and best practices. 

Thanks