Closed
Bug 1079719
Opened 10 years ago
Closed 10 years ago
Replace "greyscale" SVG filter with filter: grayscale(1)
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: dao, Assigned: nelsond5, Mentored)
References
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 2 obsolete files)
11.05 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
about:addons uses a custom "greyscale" SVG filter: > filter: url("chrome://mozapps/skin/extensions/extensions.svg#greyscale"); We should replace this with: > filter: grayscale(1); Files that need to be updated: http://mxr.mozilla.org/mozilla-central/search?string=greyscale&find=%2Fmozapps%2Fextensions%2F
Assignee | ||
Comment 1•10 years ago
|
||
Hi Could you assign me this bug please? Thanks, David
Updated•10 years ago
|
Assignee: nobody → nelsond5
Comment 2•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #0) > We should replace this with: > > > filter: grayscale(1); > and also remove extensions.svg file ?
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Ekanan Ketunuti from comment #2) > (In reply to Dão Gottwald [:dao] from comment #0) > > We should replace this with: > > > > > filter: grayscale(1); > > > > > and also remove extensions.svg file ? yes
Comment 4•10 years ago
|
||
I have replaced the custom "greyscale" SVG filter with grayscale(1) in all the files you mentioned and deleted the extensions.svg files. Can you please review my patch. Although I am not assigned the bug, will my patch merge to the main code. Thanks in advance, Kapil
Attachment #8504866 -
Flags: review?(dao)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8504866 [details] [diff] [review] Replace greyscale SVG filter with grayscale(1) You also need to remove extensions.svg from jar.mn files, otherwise the build will fail: http://mxr.mozilla.org/mozilla-central/search?string=extensions.svg&find=jar.mn Looks good otherwise!
Attachment #8504866 -
Flags: review?(dao)
Attachment #8504866 -
Flags: review-
Attachment #8504866 -
Flags: feedback+
Comment 6•10 years ago
|
||
Ok, I have removed extensions.svg from jar.mn files. Please check the attachments. Thanks, Kapil
Attachment #8505962 -
Flags: review?(dao)
Comment 7•10 years ago
|
||
Sorry, I forgot to delete extensions.svg file from extensions folder, so don't check the previous attachment. Check this one please. Thanks
Attachment #8505965 -
Flags: review?(dao)
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8505965 [details] [diff] [review] Replace greyscale SVG filter with grayscale(1) Looks good, thanks!
Attachment #8505965 -
Flags: review?(dao) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8504866 -
Attachment is obsolete: true
Reporter | ||
Updated•10 years ago
|
Attachment #8505962 -
Attachment is obsolete: true
Attachment #8505962 -
Flags: review?(dao)
Reporter | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3c8b7fa1a158
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3c8b7fa1a158
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 11•10 years ago
|
||
Hi, I'm just wondering, for future reference, is there much use in people being assigned bugs if another person comes along and fixes it? I'm doing this as part of a module at Coventry University in the UK, so just querying for future use. Thanks, David
Comment 12•10 years ago
|
||
We do much prefer it if people don't do that. You really should ask in the bug to find out if the assignee has abandoned the bug and give them a chance to respond if not. Having said that Kapil is new too and doesn't know the etiquette yet so once he does post a patch as the first thing he does we're left in a difficult position. Please don't be too discouraged, this doesn't happen often and if you want to work on some other similar bugs Dao and I can suggest some.
Assignee | ||
Comment 13•10 years ago
|
||
Thanks Robert for the response, much appreciated. I'm looking through some bugs at the moment - will get back to you if I struggle to find any others!
Comment 14•10 years ago
|
||
Thanks Robert for the support, David with all the good intentions since there was no activity on the bug for a week I safely assumed it was okay to work on it. Anyway, henceforth I will make sure that I follow the correct norms and best practices. Thanks
You need to log in
before you can comment on or make changes to this bug.
Description
•