1079724 - Clean calls and shared URLs buttons in Loop app settings should be disable if the call log or shared URLs history are empty

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Right now, in Loop application "Clean all calls" and "Clean shared links" buttons can be tapped when the Call and shared URLs history are empty.
The issue is even worse, because after clicking on them:
- "Clean all calls", asks you to confirm the deletion
- "Clean shared links" opens the menu choose between  "Clean list disable links" and "Clean all" (also with confirmation)

It'd be better to have those buttons deactivated and avoid this wrong flow

Comment 1

[Maria Angeles Oteo (:oteo)]

Setting ni to Vicky to confirm that the expected behavior should be that those buttons have to be deactivated when the Call log and the shared URLs history are empty

Comment 2

[Victoria Gerchinhoren [:vicky]]

Ideal solution would be to take them out, not show them when they are not useful. 2nd option is to have them in the disabled mode.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Use case no shared links

Comment 4

[Cristian Rodriguez (:crdlc)]

Sorry but I couldn't take a screenshot and I used my phone :(

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks Fernando for taking a look at this

Comment 6

[Cristian Rodriguez (:crdlc)]

Borja, comments addressed, thanks for your help my friend

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8501745 [details]
Github pull request

Stealing the r? for clearing the list of pending reviews. Thanks for the patch!

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8501743 [details]
Use case no shared links

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/33f411af0dac0b2ba809035f6d3169086a41604f

I've removed the ui-review? because I followed how it is working in the rest of apps e.g. contacts for instance (by means of disabled attr defined in the BB). BTW if you see something wrong please open a follow-up and immediately I gonna address that. thanks

Comment 9

[Javier de Prado]

Verified on:
Flame: user.v2.0.184based.B-57.Gecko-dde9d61.Gaia-7b8df99
FireE: firee-kk-v2.0-SW2E5-4
Loop 1.1, version: aba155c