1079755 - [LayerScope] Make different on the viewer for Layers composed by the hardware composer

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Boris Chiou [:boris]]

Some layers are composed by the hwccomposer, and others are composed by our CompositorOGL (Partially/fully hardware composed). We should also send information to LayerScope to know whether a layer is composed by the hardware composer or the OpenGL, so we can also check whether the graphic bug is related to the hardware composer or not.

Comment 1

[Boris Chiou [:boris]]

Attachment: Send composition type to Layerscope viewer (v1)

Add the composition type in meta packet to nofity users whether
this frame is composed by Hardware composer.

Comment 2

[Boris Chiou [:boris]]

Attachment: screenshot for the viewer

Use "[Hardware composition]" to let you know this frame is composed by the hardware composer.

Comment 3

[Boris Chiou [:boris]]

Attachment: Send composer info to Layerscope viewer (v2)

Add a composition info, composedByHwc, in META packet to
nofity users whether this frame is composed by Hardware composer.

Comment 4

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #3)
> Created attachment 8550133 [details] [diff] [review]
> Send composer info to Layerscope viewer (v2)
> 
> Add a composition info, composedByHwc, in META packet to
> nofity users whether this frame is composed by Hardware composer.

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d919e903031

Comment 5

[Boris Chiou [:boris]]

Attachment: MozReview Request: bz://1079755/boris

Comment 6

[Boris Chiou [:boris]]

/r/2579 - Bug 1079755 - Send composer info to Layerscope viewer

Pull down this commit:

hg pull review -r 8eed5d65e09e0ad5b5f1fe7b7b422f5313afbde4

Comment 7

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #5)
> Created attachment 8550141 [details]
> MozReview Request: bz://1079755/boris

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d919e903031

Comment 8

[Boris Chiou [:boris]]

https://reviewboard.mozilla.org/r/2577/#review1775

Ship It!

Comment 9

[Boris Chiou [:boris]]

https://reviewboard.mozilla.org/r/2577/#review1777

carry djg's r+

Comment 10

[Boris Chiou [:boris]]

https://reviewboard.mozilla.org/r/2579/#review1779

Ship It!

Comment 11

[Boris Chiou [:boris]]

https://reviewboard.mozilla.org/r/2579/#review1781

Carry djg's r+.

Comment 12

[Boris Chiou [:boris]]

Rebased and push to try again:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c55ad29ad9e7

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0028312fac1d

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0028312fac1d

Comment 16

[Boris Chiou [:boris]]

Attachment: MozReview Request: Bug 1079755 - Send composer info to Layerscope viewer