Closed
Bug 1079776
Opened 11 years ago
Closed 11 years ago
[Contact] Set ICE contact page is missing background
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fang, Assigned: makevoid, Mentored)
References
Details
(Whiteboard: [good-first-bug])
Attachments
(2 files, 1 obsolete file)
2014-10-08-15-53-28.png
Currently we are missing a setting gray background on this page.
|
||
Updated•11 years ago
|
Mentor: francisco
Whiteboard: [good-first-bug]
|
||
Comment 1•11 years ago
|
||
Hello, I would like to work on this bug, Can you assign this to me?
|
|
||
Comment 2•11 years ago
|
||
You're welcome to take it up - we can assign it to you as soon as you've submitted a patch.
Thank you!
Attachment #8515486 -
Flags: review?(francisco)
|
|
||
Updated•11 years ago
|
Assignee: nobody → makevoid
|
|
||
Updated•11 years ago
|
Attachment #8515486 -
Attachment is obsolete: true
Attachment #8515486 -
Flags: review?(francisco)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8515504 [details] [review]
slightly cleaner fix
Looking good to me,
Fang what do you think?
Attachment #8515504 -
Flags: review+
|
|
||
Updated•11 years ago
|
Attachment #8515504 -
Flags: review?(fshih)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 8515504 [details] [review]
slightly cleaner fix
It looks good! Thanks for the help!
Attachment #8515504 -
Flags: review?(fshih) → review+
|
|
||
Comment 7•11 years ago
|
||
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/e02fa748380314fd84aee0235adbc6438be9c845
Thanks for the contribution!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•