Closed Bug 1079794 Opened 8 years ago Closed 5 years ago

[Dialer] [Callscreen] When you are in active call and other call is entering you can't hold and answer with headset button

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: paco, Unassigned)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
drs
: review-
Details | Review
No description provided.
Summary: [Dialer] [Callscreen] When you are in active call and other call is entering isn't possible hold and answer with headset button → [Dialer] [Callscreen] When you are in active call and other call is entering you can't hold and answer with headset button
Assignee: nobody → pacorampas
Attached file patch in github
This is the issue that I described on https://bugzilla.mozilla.org/show_bug.cgi?id=977588#c84
Attachment #8501682 - Flags: review?(anthony)
Blocks: 977588
Comment on attachment 8501682 [details] [review]
patch in github

That makes a lot of sense :)

We'll need a new test to cover this though.
Attachment #8501682 - Flags: review?(anthony)
Attachment #8501682 - Flags: review?(anthony)
Comment on attachment 8501682 [details] [review]
patch in github

Then why are they not failing before this patch is applied? With such a change in behaviour, we need to modify the existing tests or add new ones to make sure this is working correctly.
Attachment #8501682 - Flags: review?(anthony)
No longer blocks: 977588
Attachment #8501682 - Flags: review?(anthony)
Attachment #8501682 - Flags: review?(anthony) → review?(drs+bugzilla)
Comment on attachment 8501682 [details] [review]
patch in github

I don't think this is a good fix. If there are 2 ongoing calls, it will enter the holdAndAnswer() code path anyways instead of hanging up the active one.

Instead, we should check directly for an incoming call and handle that case specifically.
Attachment #8501682 - Flags: review?(drs+bugzilla) → review-
Assignee: pacorampas → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.