1079794 - [Dialer] [Callscreen] When you are in active call and other call is entering you can't hold and answer with headset button

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Comment 1

[Paco Rampas [:paco]]

Attachment: patch in github

This is the issue that I described on https://bugzilla.mozilla.org/show_bug.cgi?id=977588#c84

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 8501682 [details] [review]
patch in github

That makes a lot of sense :)

We'll need a new test to cover this though.

Comment 3

[Paco Rampas [:paco]]

I think the test are here:
https://github.com/pacorampas/gaia/blob/master/apps/callscreen/test/unit/calls_handler_test.js#L1805

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8501682 [details] [review]
patch in github

Then why are they not failing before this patch is applied? With such a change in behaviour, we need to modify the existing tests or add new ones to make sure this is working correctly.

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8501682 [details] [review]
patch in github

I don't think this is a good fix. If there are 2 ongoing calls, it will enter the holdAndAnswer() code path anyways instead of hanging up the active one.

Instead, we should check directly for an incoming call and handle that case specifically.

Comment 6

[BMO Automation]

Firefox OS is not being worked on