107980 - content-disposition: inline - suggested filename is ignored

Status: VERIFIED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Rick DeBay]

The header "Content-Disposition" with parameter "inline; filename=somefile.ext"
is ignored when saving content.  The save name is supposed to be the one
suggested by the header, instead it's usually the URL.
The first version I tested this on was 0.9.3, and the latest was 0.9.5.

Comment 1

[CoL]

and it's there in build 2001010608 yet, it would save as: filename=somefile.ext
and not: somefile.ext.

Comment 2

[Rick DeBay]

You are incorrect.  The pertinent part of the syntax is
filename-parm := "filename" "=" value
which shows that this is a name-value pair.  The 'filename='
portion is not used as part of the file name.

Comment 3

[Boris Zbarsky [:bzbarsky]]

rick, is this still a problem?  This should have been fixed for a while now, and
I just touched the code in question -- it never looks to see what's before the
"filename=" part....  So this should work (in fact I have been unable to make it
fail).

Comment 4

[Rick DeBay]

I'll test with 0.9.8, it doesn't work with 0.9.6.  The URL I'm using is
http://minutes.co.palm-beach.fl.us/minutes/
Email me for the UID/PW if you're interested as it isn't open to the public yet.

Comment 5

[Boris Zbarsky [:bzbarsky]]

When I said "a while" I meant "since 0.9.7 or so".  So yes, testing with 0.9.8
would be good.  If you mail a UID/PW to [e-mail] so I could test with a
current trunk build, that would be much appreciated.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Got username/password in email.  Page is protected with basicauth, so bug 116279
prevents testing this (we can't save at all).  Marking dependency.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Nevermind... I was actually seeing bug 122217.  Now that I have that fixed in my
tree, I can save the image.  The filename I get prompted with is "image.gif".

Comment 8

[Rick DeBay]

That's the correct name.  I wish the system had a more descriptive
name available to me, but at least I can set the file extension.
I'll verify with 0.9.8 when it's released.
What was the fix?

Comment 9

[Boris Zbarsky [:bzbarsky]]

The fix for using the name?  A complete rewrite of the "save as" code...

Comment 10

[Darin Fisher]

OK, clue me in: is this bug FIXED/WORKSFORME now?

Comment 11

[Boris Zbarsky [:bzbarsky]]

It worksforme with current builds, yes.

Comment 12

[Darin Fisher]

marking WORKSFORME

Comment 13

[Tom Everingham]

verified - testcase at http://10.169.103.61/scripts/nph-contentdisp.pl