Closed
Bug 1079817
Opened 10 years ago
Closed 10 years ago
Add-ons manager not updating after lightweight theme is uninstalled
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(firefox32 unaffected, firefox33 unaffected, firefox34 unaffected, firefox35 verified, fennec35+)
VERIFIED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | unaffected |
firefox34 | --- | unaffected |
firefox35 | --- | verified |
fennec | 35+ | --- |
People
(Reporter: TeoVermesan, Assigned: Margaret)
References
Details
(Keywords: regression)
Attachments
(1 file)
Tested with: Device: Alcatel One Touch (Android 4.1.2) Build: Firefox for Android 35.0a1 (2014-10-08) Steps to Reproduce: 1. Go to addons.mozilla.org and install an add-on 2. Go to about:addons and tap the uninstall button Expected results: - Tapping the uninstall button, the add-on is removed and the list is empty. Actual results: - Tapping the uninstall button does nothing. - Pressing the back button, the add-on is removed. Note: video: https://www.youtube.com/watch?v=ifFvrcGInEE&feature=youtu.be
Updated•10 years ago
|
tracking-fennec: --- → ?
Keywords: regression,
regressionwindow-wanted
Updated•10 years ago
|
Flags: needinfo?(teodora.vermesan)
Assignee | ||
Comment 1•10 years ago
|
||
Is there anything in the log? Does the build you're testing include the patch for bug 1079450? That may have fixed this issue.
Reporter | ||
Comment 2•10 years ago
|
||
Tapping the uninstall button, the add-on is removed and the list is empty. Tested with the 10-09 build, works ok
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(teodora.vermesan)
Resolution: --- → WORKSFORME
Updated•10 years ago
|
tracking-fennec: ? → ---
Comment 3•10 years ago
|
||
Still reproducible on trunk (10/10) Launch Nightly (10/10) Visit and install Privacy Coach: http://people.mozilla.org/~mleibovic/coach.xpi Access the add-ons manager, see 13fox 1.0 (theme) and Privacy Coach 0.1 Tap 13fox 1.0, tap 'uninstall' Theme is uninstalled, add-on is still listed (uninstall greyed out) On uninstall: addons.xpi WARN Unable to activate the default theme addons.xpi WARN Unable to activate the default theme Tap back button, 13fox 1.0 is removed, uninstall Privacy Coach and that works fine. I think this might be a problem where two extensions are bundled from the same add-on maybe?
Status: RESOLVED → REOPENED
tracking-fennec: --- → ?
Resolution: WORKSFORME → ---
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #3) > Still reproducible on trunk (10/10) > > Launch Nightly (10/10) > Visit and install Privacy Coach: > http://people.mozilla.org/~mleibovic/coach.xpi > Access the add-ons manager, see 13fox 1.0 (theme) and Privacy Coach 0.1 > Tap 13fox 1.0, tap 'uninstall' > > Theme is uninstalled, add-on is still listed (uninstall greyed out) Are you saying you expect the add-on to be uninstalled when you uninstall the theme? I don't think that should happen. > On uninstall: > > addons.xpi WARN Unable to activate the default theme > addons.xpi WARN Unable to activate the default theme > > Tap back button, 13fox 1.0 is removed, uninstall Privacy Coach and that > works fine. > > I think this might be a problem where two extensions are bundled from the > same add-on maybe? There's logic in the uninstall handler to uninstall the theme, but we can't do that if the user already uninstalled the theme, which is what's leading to that warning. We could probably just be more defensive there.
Blocks: 1064856
Comment 5•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #4) > (In reply to Aaron Train [:aaronmt] from comment #3) > > Still reproducible on trunk (10/10) > > > > Launch Nightly (10/10) > > Visit and install Privacy Coach: > > http://people.mozilla.org/~mleibovic/coach.xpi > > Access the add-ons manager, see 13fox 1.0 (theme) and Privacy Coach 0.1 > > Tap 13fox 1.0, tap 'uninstall' > > > > Theme is uninstalled, add-on is still listed (uninstall greyed out) > > Are you saying you expect the add-on to be uninstalled when you uninstall > the theme? I don't think that should happen. I expect the installed theme to be uninstalled correctly when I tap uninstall. After tapping uninstall I sholud be at the add-on listing again and only see 'Privacy Coach 0.1' if thats' all I have installed.
Assignee | ||
Comment 6•10 years ago
|
||
Okay, I just reproduced this. I'll look into it.
Assignee: nobody → margaret.leibovic
Assignee | ||
Updated•10 years ago
|
Summary: The add-on is removed only the second time the user enters the add-ons management screen after uninstalling it → Add-ons manager not updating after lightweight theme is uninstalled
Assignee | ||
Comment 7•10 years ago
|
||
Actually the problem here is with bug 1079450, not the privacy coach add-on.
Keywords: regressionwindow-wanted
Assignee | ||
Comment 8•10 years ago
|
||
Comparing the add-on objects themselves is failing, and I'm having a hard time trying to use the debugger to find out exactly why. However, comparing the ids is sufficient, and this fixes the problem for me locally.
Attachment #8504164 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8504164 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/002cba453c89
https://hg.mozilla.org/mozilla-central/rev/002cba453c89
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
tracking-fennec: ? → 35+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•