Closed
Bug 1079848
Opened 10 years ago
Closed 10 years ago
Large OOM in mozilla::WebGLContext::TexImage2D_base
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
VERIFIED
FIXED
mozilla36
People
(Reporter: cbadau, Assigned: jgilbert)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
2.15 KB,
patch
|
jgilbert
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
bkerensa
:
approval-mozilla-esr31+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and it's crash report is: https://crash-stats.mozilla.com/report/index/bp-4202571a-33ac-47a7-9aa7-211bf2141008 . I had Google Maps, Youtube and many other sites opened. I don't have proper STR but it crashes while navigating on Google Maps, on street view for quite a while (>15 minutes). I reproduced the crash on Firefox 33 RC on Windows 7 32bit. In the last week 1276 crashes on Windows 7 32bit occured with this signature. Other crash reports: https://crash-stats.mozilla.com/report/index/d3738afa-2806-4f56-b6f8-4fe5d2140909 https://crash-stats.mozilla.com/report/index/ba569f13-e9f9-4325-829f-8a37b2140910
Updated•10 years ago
|
Summary: Crash in [@ OOM | large | mozalloc_abort(char const* const) | mozalloc_handle_oom(unsigned int) | moz_xmalloc | mozilla::WebGLContext::TexImage2D_base(unsigned int, int, unsigned int, int, int, int, int, unsigned int, unsigned int, void*, unsigned int, in → Large OOM in mozilla::WebGLContext::TexImage2D_base
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → jgilbert
Attachment #8503492 -
Flags: review?(dglastonbury)
Attachment #8503492 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc127a8d08f6
Assignee | ||
Comment 3•10 years ago
|
||
r=kamidphish
Attachment #8503492 -
Attachment is obsolete: true
Attachment #8504291 -
Flags: review+
Comment 4•10 years ago
|
||
All good except for the patch description, which says "infallible and handled" instead of "fallible and handled". :-) (Made me stop and look.)
Assignee | ||
Comment 5•10 years ago
|
||
Ahhh, annoying! Sorry about that!
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8504291 [details] [diff] [review] 0001-Large-allocs-should-be-fallible-and-handled.patch Approval Request Comment [Feature/regressing bug #]: n/a [User impact if declined]: Crashes! [Describe test coverage new/current, TBPL]: None. [Risks and why]: Negative. :P [String/UUID change made/needed]: None.
Attachment #8504291 -
Flags: approval-mozilla-beta?
Attachment #8504291 -
Flags: approval-mozilla-aurora?
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc127a8d08f6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8504291 -
Flags: approval-mozilla-beta?
Attachment #8504291 -
Flags: approval-mozilla-beta+
Attachment #8504291 -
Flags: approval-mozilla-aurora?
Attachment #8504291 -
Flags: approval-mozilla-aurora+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4b51521d72db https://hg.mozilla.org/releases/mozilla-beta/rev/03d4ab96c271
Assignee | ||
Comment 9•10 years ago
|
||
Thanks!
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/03d4ab96c271
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Updated•10 years ago
|
Flags: qe-verify+
QA Contact: camelia.badau
Reporter | ||
Comment 11•10 years ago
|
||
I verified the bug on Windows 7 32bit using Firefox 34 Beta 2 (buildID: 20141020184313) and it seems to be fixed (no crash occurs). I'll keep an eye on Soccoro in the next couple of days to ensure that no crashes will occur before changing the Status of the bug.
Comment 12•10 years ago
|
||
Checking Soccoro no other crashes were noticed on FF34.0b, FF35 and FF36 versions on the latest 4 weeks post fix. Marking this bug as verified
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
status-firefox-esr31:
--- → affected
Comment 13•9 years ago
|
||
https://crash-stats.mozilla.com/search/?signature=~OOM+|+large+|+mozalloc_abort%28char+const*+const%29+|+mozalloc_handle_oom%28unsigned+int%29+|+moz_xmalloc+|+mozilla%3A%3AWebGLContext%3A%3ATexImage2D_base%28unsigned+int%2C+int%2C+unsigned+int%2C+int%2C+int%2C+int%2C+int%2C+unsigned+int%2C+unsigned+int%2C+void*%2C+unsigned+int%2C+int%2C+mozill...&version=31.3.0esr&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports Can this uplift to esr31?
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8504291 [details] [diff] [review] 0001-Large-allocs-should-be-fallible-and-handled.patch [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Low risk OOM fix. User impact if declined: OOMs. Fix Landed on Version: 36 Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Flags: needinfo?(jgilbert)
Attachment #8504291 -
Flags: approval-mozilla-esr31?
Updated•9 years ago
|
Attachment #8504291 -
Flags: approval-mozilla-esr31? → approval-mozilla-esr31+
You need to log in
before you can comment on or make changes to this bug.
Description
•