[Loop]: Use WebApp's manifests instead of locales.ini

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
See bug 1022767
(Assignee)

Updated

4 years ago
Whiteboard: [mobile app]
(Assignee)

Updated

4 years ago
Summary: Bug 1022767 - Use WebApp's manifests instead of locales.ini → Use WebApp's manifests instead of locales.ini
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8501786 [details]
Github pull request
Attachment #8501786 - Flags: review?(borja.bugzilla)
Blocks: 988276
(Assignee)

Comment 2

4 years ago
Comment on attachment 8501786 [details]
Github pull request

Hi Axel,

   Could you take a look at this patch? I've implemented these tasks and I would like to know if it is ok or I missed something.

1) Updated l10n library
2) Updated manifest.webapp and prepared for localization
3) Updated index.html to set the new paths to properties files
4) Deleted <br> from locales
5) Fixed the markup because there were a tag which wasn't closed and the localization failed

Thanks a lot for your time
Attachment #8501786 - Flags: feedback?(l10n)
You're making assumptions on the language structure here

-loggedInAs = You're logged in as <br> {{username}}
+loggedInAs = You're logged in as

As in: you can't be sure that the username is going to work at the end of the sentence. You should leave a placeholder.

You're also reusing the "unknown" string. I'd suggest to have a specific string that talks about "unknown user".

Other doubt (leaving f? open): I don't think that we want "Firefox Hello" as a localizable string.
Summary: Use WebApp's manifests instead of locales.ini → [Loop]: Use WebApp's manifests instead of locales.ini
(Assignee)

Comment 4

4 years ago
Comments addressed Francesco, maybe you would like to take a look again, thanks a lot for your time
Flags: needinfo?(francesco.lodolo)
String-wise it looks good to me now (with the doubt about "Firefox Hello").
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 6

4 years ago
Firefox Hello has been removed 

https://github.com/mozilla-b2g/firefoxos-loop-client/pull/171/files#diff-964b329a1e6469f66cec3e4991fbb538L2

Now this is defined in js

https://github.com/mozilla-b2g/firefoxos-loop-client/pull/171/files#diff-88824f0fb2947afec9c4bc50f3224cfbR1

it implies no translations for branding as you suggested correctly IMHO



(In reply to Francesco Lodolo [:flod] from comment #5)
> String-wise it looks good to me now (with the doubt about "Firefox Hello").
(In reply to Cristian Rodriguez (:crdlc) from comment #6)
> it implies no translations for branding as you suggested correctly IMHO

Exactly, but I want to see Pike's opinion on it ;-)
Comment on attachment 8501786 [details]
Github pull request

The branding question is really a product/legal decision.

There are basically three levels of choice, with different balance between policy and adaptibility

- hard-code the brand. This guarantees that the brand is literally appearing as the same sequence of glyphs. Depending on the code referencing the brand, you can add pre- and postfixes.
- expose the brand to localizers, but policy to keep it intact, unless there are explicit exceptions, granted on a one-off basis.
- have a localized brand. Requires quite a bit of skill on the localizer front to find a great brand, but also makes sure that the brand is best-suiting market.

Technically this looks good, and the l12y stuff flod mostly covered. I checked with gandalf if there's something better to recommend instead of the innerHTML, but that's WIP. No reason to hold back on that.

Great to see the update here to a current backbone. Here I can loop (hic) in help, and get good answers.
Attachment #8501786 - Flags: feedback?(l10n) → feedback+
(Assignee)

Comment 9

4 years ago
and also removed unused strings
Comment on attachment 8501786 [details]
Github pull request

Thanks!! Great job here!
Attachment #8501786 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 11

4 years ago
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/433c206f125419e83e08d91435177803637cdf34
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Blocks: 1083138
No longer blocks: 988276
Tested, German language in Loop Mobile client.

Two scenarios tested:
1. User changes to German/English and Spanish when  Loop is open.
2. Device with German/English and Spanish languaje selected and after Loop is installed.

Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.