Closed Bug 1079869 Opened 6 years ago Closed 6 years ago
Hitting enter after interacting with options from Forget button closes the pop-up
STR: 1. Open Firefox 2. Move the Forget button to toolbar 3. Click the button and select one of the options (eg. 24 hours) 4. Using the arrow keys (up/down) move through the options 5. Hit Enter key Expected results: Maybe after selecting an option using arrow keys, hitting enter will actually have the same behavior as clicking 'Forget'. Actual results: After hitting Enter the pop-up just closes. Notes: 1. Windows and Linux only. 2. Reproducible on latest Nightly and latest Aurora.
This should be fixable by adding closemenu=none on the radio buttons.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Points: --- → 1
This works in my testing; the event target is the radiogroup because that's a XBL binding so the original individual radio button targets get lost (yay XBL) and putting the attribute on there doesn't work...
Attachment #8503031 - Flags: review?(jaws)
Attachment #8503031 - Flags: review?(jaws) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8503031 [details] [diff] [review] fix closing forget panel by adding a closemenu=none attribute, (approval req for 34) Approval Request Comment [Feature/regressing bug #]: panic button [User impact if declined]: in some cases, panel will close if you use the keyboard when it shouldn't [Describe test coverage new/current, TBPL]: nope [Risks and why]: nope [String/UUID change made/needed]: nope
Landed in alder: https://hg.mozilla.org/projects/alder/rev/0de8444b8da0
(The 33/alder patch was based on e6441f98f159)
Verified as fixed on Windows 7 64bit and Ubuntu 12.04 32bit using Firefox 34 beta 3 build 2, latest Aurora and latest Alder build.
Also verified using Firefox 33.1 on Windows 7 64bit, Ubuntu 14.04 32bit and it is fixed.
You need to log in before you can comment on or make changes to this bug.