1079869 - Hitting enter after interacting with options from Forget button closes the pop-up

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

STR:
1. Open Firefox
2. Move the Forget button to toolbar
3. Click the button and select one of the options (eg. 24 hours)
4. Using the arrow keys (up/down) move through the options
5. Hit Enter key

Expected results: Maybe after selecting an option using arrow keys, hitting enter will actually have the same behavior as clicking 'Forget'.

Actual results: After hitting Enter the pop-up just closes.

Notes:
1. Windows and Linux only.
2. Reproducible on latest Nightly and latest Aurora.

Comment 1

[:Gijs (he/him)]

This should be fixable by adding closemenu=none on the radio buttons.

Comment 2

[:Gijs (he/him)]

Attachment: fix closing forget panel by adding a closemenu=none attribute,

This works in my testing; the event target is the radiogroup because that's a XBL binding so the original individual radio button targets get lost (yay XBL) and putting the attribute on there doesn't work...

Comment 3

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/c6e8abf0f825

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c6e8abf0f825

Comment 5

[:Gijs (he/him)]

Comment on attachment 8503031 [details] [diff] [review]
fix closing forget panel by adding a closemenu=none attribute,

(approval req for 34)

Approval Request Comment
[Feature/regressing bug #]: panic button
[User impact if declined]: in some cases, panel will close if you use the keyboard when it shouldn't
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: nope
[String/UUID change made/needed]: nope

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This landed prior to the uplift.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e6441f98f159

Comment 8

[Justin Dolske [:Dolske]]

Landed in alder: https://hg.mozilla.org/projects/alder/rev/0de8444b8da0

Comment 9

[Justin Dolske [:Dolske]]

(The 33/alder patch was based on e6441f98f159)

Comment 10

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

Verified as fixed on Windows 7 64bit and Ubuntu 12.04 32bit using Firefox 34 beta 3 build 2, latest Aurora and latest Alder build.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0de8444b8da0

Comment 12

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

Also verified using Firefox 33.1 on Windows 7 64bit, Ubuntu 14.04 32bit and it is fixed.