Closed Bug 1079891 Opened 5 years ago Closed 5 years ago

Search widget not available for adding to a Android homescreen on the Android One (and likely other devices); fixed widget size can not fit on the device

Categories

(Firefox for Android :: General, defect)

35 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 37
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed
fennec 35+ ---

People

(Reporter: aaronmt, Assigned: mfinkle)

References

Details

Attachments

(4 files)

I just unboxed this Android One, installed Nightly and off the bat with things on the list broken, I do not see the widget available for adding to an Android homescreen. However, the lockscreen widget is available for adding.

--
ro.build.version.sdk=19
ro.build.version.codename=REL
ro.build.version.release=4.4.4
ro.build.product=sprout

Android One Dream UNO (4.4.4)
Nightly (10/08)
Is the allow widgets preference checked in the Android security settings?
Yes. Double checked if it was a regression in general on other devices, I see the widget available for adding on my HTC One (M7). No particular errors through logging from the PackageManager when installing.
(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> Is the allow widgets preference checked in the Android security settings?

Also, that preference is only for allowing/disallowing lock-screen widgets. When enabled, it adds an empty pane with the big + button.
Can you try installing a different 3rd party app and see if the widgets for it are shown?
tracking-fennec: ? → +
Flags: needinfo?(aaron.train)
I installed Today Calendar off Google Play which includes a number of widgets and they were all available. Checked again with a reinstall of Nightly on the device today and still no widget appearing in the list. I wonder if some requirement is not met, and wether this can be shown somewhere.

Anyone else have the Spice Dream Uno?
Flags: needinfo?(aaron.train)
Actually just spotted this

E/AppsCustomizePagedView(  789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60)

E/AppsCustomizePagedView(  789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60)
Summary: Search widget not available for adding to a Android homescreen on the Android One → Search widget not available for adding to a Android homescreen on the Android One (and likely other devices); fixed widget size can not fit on the device
tracking-fennec: + → ?
Assignee: nobody → wjohnston
tracking-fennec: ? → 35+
Blocks: widget
The search widget min-width is set here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/search_widget_info.xml#7

I picked that number a bit... randomly. So someone with access to a One, feel free to tweak it.
This patch makes the widget installable on my Spice AndroidOne phone. I used 250dp, which is suggested as a minWidth for widgets taking up 4 "grid cells", which our widget does:

http://developer.android.com/guide/practices/ui_guidelines/widget_design.html

Using 250dp doesn't cause a change on my Nexus S or Galaxy Nexus. Screenshots coming.
Assignee: wjohnston → mark.finkle
Attachment #8529518 - Flags: review?(wjohnston)
New width on a Spice AndroidOne. Android 4+ adds a nice padding around the widget.
Attached image nexuss-2.3-widget.png
New width on a Nexus S. Android 2.3 does not add a nice padding around the widget. The current widget width looks the same.
Attached image galaxy-nexus-widget.png
New width on a Galaxy Nexus (top) and the current width widget (bottom). This helps show how Android will change the displayed width based on the "grid cell" concept.
Attachment #8529518 - Flags: review?(wjohnston) → review+
Comment on attachment 8529518 [details] [diff] [review]
widget-minwidth v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Widget will not install to home screen on some phones
[Describe test coverage new/current, TBPL]: Manual because it's device dependent
[Risks and why]: low risk
[String/UUID change made/needed]: none
Attachment #8529518 - Flags: approval-mozilla-beta?
Attachment #8529518 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f3de43973318
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8529518 - Flags: approval-mozilla-beta?
Attachment #8529518 - Flags: approval-mozilla-beta+
Attachment #8529518 - Flags: approval-mozilla-aurora?
Attachment #8529518 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.