Closed
Bug 1079891
Opened 10 years ago
Closed 9 years ago
Search widget not available for adding to a Android homescreen on the Android One (and likely other devices); fixed widget size can not fit on the device
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 fixed, firefox36 fixed, firefox37 fixed, fennec35+)
RESOLVED
FIXED
Firefox 37
People
(Reporter: aaronmt, Assigned: mfinkle)
References
Details
Attachments
(4 files)
1.05 KB,
patch
|
wesj
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
761.04 KB,
image/png
|
Details | |
367.48 KB,
image/png
|
Details | |
563.67 KB,
image/png
|
Details |
I just unboxed this Android One, installed Nightly and off the bat with things on the list broken, I do not see the widget available for adding to an Android homescreen. However, the lockscreen widget is available for adding. -- ro.build.version.sdk=19 ro.build.version.codename=REL ro.build.version.release=4.4.4 ro.build.product=sprout Android One Dream UNO (4.4.4) Nightly (10/08)
Comment 1•10 years ago
|
||
Is the allow widgets preference checked in the Android security settings?
Reporter | ||
Comment 2•10 years ago
|
||
Yes. Double checked if it was a regression in general on other devices, I see the widget available for adding on my HTC One (M7). No particular errors through logging from the PackageManager when installing.
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #1) > Is the allow widgets preference checked in the Android security settings? Also, that preference is only for allowing/disallowing lock-screen widgets. When enabled, it adds an empty pane with the big + button.
Assignee | ||
Comment 4•10 years ago
|
||
Can you try installing a different 3rd party app and see if the widgets for it are shown?
tracking-fennec: ? → +
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(aaron.train)
Reporter | ||
Comment 5•10 years ago
|
||
I installed Today Calendar off Google Play which includes a number of widgets and they were all available. Checked again with a reinstall of Nightly on the device today and still no widget appearing in the list. I wonder if some requirement is not met, and wether this can be shown somewhere. Anyone else have the Spice Dream Uno?
Flags: needinfo?(aaron.train)
Reporter | ||
Comment 6•10 years ago
|
||
Actually just spotted this E/AppsCustomizePagedView( 789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60) E/AppsCustomizePagedView( 789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60)
Reporter | ||
Comment 7•10 years ago
|
||
http://stackoverflow.com/questions/14525433/android-tablet-nexus-10-got-exception-on-widget-cannot-fit-on-this-device
Reporter | ||
Updated•10 years ago
|
Summary: Search widget not available for adding to a Android homescreen on the Android One → Search widget not available for adding to a Android homescreen on the Android One (and likely other devices); fixed widget size can not fit on the device
Reporter | ||
Comment 8•10 years ago
|
||
http://androidxref.com/4.4.4_r1/xref/packages/apps/Launcher2/src/com/android/launcher2/AppsCustomizePagedView.java#463 http://androidxref.com/4.4.4_r1/xref/packages/apps/Launcher3/src/com/android/launcher3/AppsCustomizePagedView.java#464
Reporter | ||
Updated•10 years ago
|
tracking-fennec: + → ?
Updated•10 years ago
|
Assignee: nobody → wjohnston
tracking-fennec: ? → 35+
Comment 9•10 years ago
|
||
The search widget min-width is set here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/search_widget_info.xml#7 I picked that number a bit... randomly. So someone with access to a One, feel free to tweak it.
Assignee | ||
Comment 10•9 years ago
|
||
This patch makes the widget installable on my Spice AndroidOne phone. I used 250dp, which is suggested as a minWidth for widgets taking up 4 "grid cells", which our widget does: http://developer.android.com/guide/practices/ui_guidelines/widget_design.html Using 250dp doesn't cause a change on my Nexus S or Galaxy Nexus. Screenshots coming.
Assignee: wjohnston → mark.finkle
Attachment #8529518 -
Flags: review?(wjohnston)
Assignee | ||
Comment 11•9 years ago
|
||
New width on a Spice AndroidOne. Android 4+ adds a nice padding around the widget.
Assignee | ||
Comment 12•9 years ago
|
||
New width on a Nexus S. Android 2.3 does not add a nice padding around the widget. The current widget width looks the same.
Assignee | ||
Comment 13•9 years ago
|
||
New width on a Galaxy Nexus (top) and the current width widget (bottom). This helps show how Android will change the displayed width based on the "grid cell" concept.
Updated•9 years ago
|
Attachment #8529518 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f3de43973318
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8529518 [details] [diff] [review] widget-minwidth v0.1 Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: Widget will not install to home screen on some phones [Describe test coverage new/current, TBPL]: Manual because it's device dependent [Risks and why]: low risk [String/UUID change made/needed]: none
Attachment #8529518 -
Flags: approval-mozilla-beta?
Attachment #8529518 -
Flags: approval-mozilla-aurora?
Comment 16•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3de43973318
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8529518 -
Flags: approval-mozilla-beta?
Attachment #8529518 -
Flags: approval-mozilla-beta+
Attachment #8529518 -
Flags: approval-mozilla-aurora?
Attachment #8529518 -
Flags: approval-mozilla-aurora+
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/55cd17a0f25b https://hg.mozilla.org/releases/mozilla-beta/rev/04d07fa295fd
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•