1079891 - Search widget not available for adding to a Android homescreen on the Android One (and likely other devices); fixed widget size can not fit on the device

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

I just unboxed this Android One, installed Nightly and off the bat with things on the list broken, I do not see the widget available for adding to an Android homescreen. However, the lockscreen widget is available for adding.

--
ro.build.version.sdk=19
ro.build.version.codename=REL
ro.build.version.release=4.4.4
ro.build.product=sprout

Android One Dream UNO (4.4.4)
Nightly (10/08)

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Is the allow widgets preference checked in the Android security settings?

Comment 2

[Aaron Train [:aaronmt]]

Yes. Double checked if it was a regression in general on other devices, I see the widget available for adding on my HTC One (M7). No particular errors through logging from the PackageManager when installing.

Comment 3

[Aaron Train [:aaronmt]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> Is the allow widgets preference checked in the Android security settings?

Also, that preference is only for allowing/disallowing lock-screen widgets. When enabled, it adds an empty pane with the big + button.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Can you try installing a different 3rd party app and see if the widgets for it are shown?

Comment 5

[Aaron Train [:aaronmt]]

I installed Today Calendar off Google Play which includes a number of widgets and they were all available. Checked again with a reinstall of Nightly on the device today and still no widget appearing in the list. I wonder if some requirement is not met, and wether this can be shown somewhere.

Anyone else have the Spice Dream Uno?

Comment 6

[Aaron Train [:aaronmt]]

Actually just spotted this

E/AppsCustomizePagedView(  789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60)

E/AppsCustomizePagedView(  789): Widget ComponentInfo{org.mozilla.fennec/org.mozilla.search.SearchWidget} can not fit on this device (450, 60)

Comment 7

[Aaron Train [:aaronmt]]

http://stackoverflow.com/questions/14525433/android-tablet-nexus-10-got-exception-on-widget-cannot-fit-on-this-device

Comment 8

[Aaron Train [:aaronmt]]

http://androidxref.com/4.4.4_r1/xref/packages/apps/Launcher2/src/com/android/launcher2/AppsCustomizePagedView.java#463

http://androidxref.com/4.4.4_r1/xref/packages/apps/Launcher3/src/com/android/launcher3/AppsCustomizePagedView.java#464

Comment 9

[Wesley Johnston (:wesj)]

The search widget min-width is set here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/xml/search_widget_info.xml#7

I picked that number a bit... randomly. So someone with access to a One, feel free to tweak it.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: widget-minwidth v0.1

This patch makes the widget installable on my Spice AndroidOne phone. I used 250dp, which is suggested as a minWidth for widgets taking up 4 "grid cells", which our widget does:

http://developer.android.com/guide/practices/ui_guidelines/widget_design.html

Using 250dp doesn't cause a change on my Nexus S or Galaxy Nexus. Screenshots coming.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: spice-android-one-widget.png

New width on a Spice AndroidOne. Android 4+ adds a nice padding around the widget.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: nexuss-2.3-widget.png

New width on a Nexus S. Android 2.3 does not add a nice padding around the widget. The current widget width looks the same.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: galaxy-nexus-widget.png

New width on a Galaxy Nexus (top) and the current width widget (bottom). This helps show how Android will change the displayed width based on the "grid cell" concept.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/f3de43973318

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8529518 [details] [diff] [review]
widget-minwidth v0.1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Widget will not install to home screen on some phones
[Describe test coverage new/current, TBPL]: Manual because it's device dependent
[Risks and why]: low risk
[String/UUID change made/needed]: none

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3de43973318

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55cd17a0f25b
https://hg.mozilla.org/releases/mozilla-beta/rev/04d07fa295fd