Test for update of Trusted Hosted Apps

UNCONFIRMED
Unassigned

Status

UNCONFIRMED
4 years ago
a year ago

People

(Reporter: zoran.jovanovic, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8501783 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch
Attachment #8501783 - Flags: review?(fabrice)
(Reporter)

Updated

4 years ago
Depends on: 1077529, 1071085
Comment on attachment 8501783 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8501783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I'm just holding on r+ until we can push that to try.

::: dom/apps/tests/test_trusted_app_install.js
@@ +68,4 @@
>      });
>    }
>  
> +  function updateApp(app) {

nit: rename to checkForUpdate() since this is what it's actually wrapping.
Attachment #8501783 - Flags: review?(fabrice) → feedback+
(Reporter)

Comment 2

4 years ago
Created attachment 8508726 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

- Fixed the latest comment from Fabrice (rename of function).
- Still waiting for try access.
Attachment #8501783 - Attachment is obsolete: true
Attachment #8508726 - Flags: review?(fabrice)
Comment on attachment 8508726 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8508726 [details] [diff] [review]:
-----------------------------------------------------------------

Look fine, but we need a try build before landing.
Attachment #8508726 - Flags: review?(fabrice) → review+

Updated

a year ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.