Closed Bug 1079915 Opened 8 years ago Closed 4 years ago

Test for update of Trusted Hosted Apps

Categories

(Core Graveyard :: DOM: Apps, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: zoran.jovanovic, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8501783 - Flags: review?(fabrice)
Depends on: 1077529, 1071085
Comment on attachment 8501783 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8501783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I'm just holding on r+ until we can push that to try.

::: dom/apps/tests/test_trusted_app_install.js
@@ +68,4 @@
>      });
>    }
>  
> +  function updateApp(app) {

nit: rename to checkForUpdate() since this is what it's actually wrapping.
Attachment #8501783 - Flags: review?(fabrice) → feedback+
- Fixed the latest comment from Fabrice (rename of function).
- Still waiting for try access.
Attachment #8501783 - Attachment is obsolete: true
Attachment #8508726 - Flags: review?(fabrice)
Comment on attachment 8508726 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8508726 [details] [diff] [review]:
-----------------------------------------------------------------

Look fine, but we need a try build before landing.
Attachment #8508726 - Flags: review?(fabrice) → review+
Product: Core → Core Graveyard
Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.