1079963 - Build partner landing page template

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Matt Thompson (@OpenMatt :OpenMatt)]

* Once the design is done, we'll need to build it

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Aki: I'm not sure if this  ticket is entirely blocked on bug 1079472, or whether there's some early prep work you can do to get started?

Comment 2

[Aki Rose Braun [:akirose]]

It's totally blocked. All the prep work I could do would be the stuff I did already.

Comment 3

[Matt Thompson (@OpenMatt :OpenMatt)]

* Ok thanks Aki.

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* Aki: the design work in bug 1079472 is now complete, so I believe this is now unblocked :)

Comment 5

[Matt Thompson (@OpenMatt :OpenMatt)]

* Aki: not sure whether this ticket was included in what you, Wex and Gavin discussed today.
* Can you update the status here? And let us know if we should grab a quick huddle Friday morning in IRC or Vidyo?

Comment 6

[Matt Thompson (@OpenMatt :OpenMatt)]

* Next step: Gavin and Wex will touch base and update here on when they think this can land

Comment 7

[Matt Thompson (@OpenMatt :OpenMatt)]

* Can we get a quick status update on this ticket today before 12:30pm ET? 
* It's ok if it's not done -- but we'll do a complete Fall Campaign status check today and so want to review final open tickets.

Comment 8

[Gavin Suntop [:gvn]]

I missed this ticket last week since it's whiteboarded [oct31] and thus haven't started yet.

I'll need a PSDs to the template. I'm also not clear where this page lives? I'll ping you and Aki shortly...

Comment 9

[Gavin Suntop [:gvn]]

Ok, sounds like this is a new template to be built in https://github.com/mozilla/webmaker-landing-pages and to live on welcome.webmaker.org.

Please correct me if that's wrong.

Comment 10

[Gavin Suntop [:gvn]]

Cassie, can you point me to the final PSD for this template?

Comment 11

[Matt Thompson (@OpenMatt :OpenMatt)]

(In reply to Gavin Suntop [:gvn] from comment #9)

> sounds like this is a new template to be built in
> https://github.com/mozilla/webmaker-landing-pages and to live on
> welcome.webmaker.org.

Yes indeed. Thanks Gavin.

Comment 12

[Cassie McDaniel [:cassiemc]]

PSD is here as soon as it's finished uploading: https://www.dropbox.com/s/acbluf8rjcd4noi/partner-template-v4.psd?dl=0

Comment 13

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/97

View template example at:

http://localhost:9006/partner/

Comment 14

[Matt Thompson (@OpenMatt :OpenMatt)]

* Aki: this ticket is a priority. Can you try to get to your review asap?

Comment 15

[Gavin Suntop [:gvn]]

Template built and landed. 

No specific partner pages have been created. If this is desired please file a follow up ticket(s).

Thanks!

Comment 16

[Matt Thompson (@OpenMatt :OpenMatt)]

* Gavin: can you put the template example on staging or someplace where we can more easily do review and QA?

Comment 17

[Gavin Suntop [:gvn]]

This should work at https://welcome.mofostaging.net/partner/ (works locally)

Jbuck, it appears that some paths aren't resolving. I modified the gruntfile for this template/page, so not sure if that may need something tweaked with deployment?

Comment 18

[Jon Buckley [:jbuck]]

The root problem seems to be that the output of grunt build and grunt dev are different.

Comment 19

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/100

This should fix the missing asset issue.

Comment 20

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/101

So, I was wondering how the other pages did the style copying without adding a new block to the concat grunt task and I saw they used that usemin syntax. Then I tried to get it working locally, and essentially ended up with a new patch. Sorry :(

Comment 21

[Matt Thompson (@OpenMatt :OpenMatt)]

* Thanks guys. What are the next steps and time estimate for closing this ticket?

Comment 22

[Gavin Suntop [:gvn]]

I'm about to look Jon's patch now. If that works it should resolve this ticket.

Comment 23

[Gavin Suntop [:gvn]]

Comment on attachment 8517111 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/101

That works too. :)

Comment 24

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/446eb3dde1bee958460eb58199222b1e53f792e7
Fix bug 1079963 - Add usemin syntax for partner page styles

Comment 25

[Ricardo Vazquez [:ricardo]]

The new partner landing pages look like this: https://welcome.mofostaging.net/partner/