1080012 - Fennec no longer able to mirror tabs on chromecast

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Randall Barker [:rbarker]]

Both the TabMirror module in fennec the and chromecast mirror application have stopped working.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Chromecast tab mirror fix v1.

This fixes the TabMirror.jsm syntax error where the pc variable was declared twice in the same scope. Also changes the ID of the chromecast application to point the chromecast to a url that contains a fixed tab mirroring application.

Comment 2

[Randall Barker [:rbarker]]

Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Still need to clean up the chromecast application and find a proper host for it, but this should unbreak nightly.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Go!

Comment 4

[Randall Barker [:rbarker]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=be3004f5578c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/66e733f48747

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The try run only had builds. Hopefully that doesn't bite us.

Comment 7

[Randall Barker [:rbarker]]

(In reply to Wes Kocher (:KWierso) from comment #6)
> The try run only had builds. Hopefully that doesn't bite us.

Sadly there is no test coverage for this feature, tab mirroring to a chromecast :(

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66e733f48747

Comment 9

[Randall Barker [:rbarker]]

Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Approval Request Comment
[Feature/regressing bug #]:Tab Mirror from Fennec to Chromecast
[User impact if declined]:Fennec is unable to start a tab mirror session and leaves the chromecast with a blank black screen.
[Describe test coverage new/current, TBPL]: I don't believe tab mirror has any test coverage.
[Risks and why]: None known.
[String/UUID change made/needed]:none

Bug 1080701 which will also need to be uplifted depends on this patch.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Beta+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/25b64ba60455

Comment 12

[Flaviu Cos]

Verified as fixed in builds:
- 36.0a1 2014-11-25;
- 35.0a2 2014-11-25;
- 34 RC1;
Device: Nexus 4 (Android 4.4.4).