Closed Bug 1080012 Opened 5 years ago Closed 5 years ago

Fennec no longer able to mirror tabs on chromecast

Categories

(Firefox for Android :: Screencasting, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox34 --- verified
firefox35 --- verified
firefox36 --- verified

People

(Reporter: rbarker, Assigned: rbarker)

Details

Attachments

(1 file)

Both the TabMirror module in fennec the and chromecast mirror application have stopped working.
Assignee: nobody → rbarker
This fixes the TabMirror.jsm syntax error where the pc variable was declared twice in the same scope. Also changes the ID of the chromecast application to point the chromecast to a url that contains a fixed tab mirroring application.
Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Still need to clean up the chromecast application and find a proper host for it, but this should unbreak nightly.
Attachment #8501908 - Flags: review?(wjohnston)
Attachment #8501908 - Flags: review?(mark.finkle)
Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Go!
Attachment #8501908 - Flags: review?(wjohnston)
Attachment #8501908 - Flags: review?(mark.finkle)
Attachment #8501908 - Flags: review+
Keywords: checkin-needed
The try run only had builds. Hopefully that doesn't bite us.
(In reply to Wes Kocher (:KWierso) from comment #6)
> The try run only had builds. Hopefully that doesn't bite us.

Sadly there is no test coverage for this feature, tab mirroring to a chromecast :(
https://hg.mozilla.org/mozilla-central/rev/66e733f48747
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Approval Request Comment
[Feature/regressing bug #]:Tab Mirror from Fennec to Chromecast
[User impact if declined]:Fennec is unable to start a tab mirror session and leaves the chromecast with a blank black screen.
[Describe test coverage new/current, TBPL]: I don't believe tab mirror has any test coverage.
[Risks and why]: None known.
[String/UUID change made/needed]:none

Bug 1080701 which will also need to be uplifted depends on this patch.
Attachment #8501908 - Flags: approval-mozilla-beta?
Comment on attachment 8501908 [details] [diff] [review]
Chromecast tab mirror fix v1.

Beta+
Attachment #8501908 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed in builds:
- 36.0a1 2014-11-25;
- 35.0a2 2014-11-25;
- 34 RC1;
Device: Nexus 4 (Android 4.4.4).
You need to log in before you can comment on or make changes to this bug.