1080016 - Display favicons properly after interrupted page loads

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Mark Capella [:capella]]

Attachment: bookmarkFaviconBug.diff

This fixes a small display issue.

STR to observe the issue is simple:
   In Settings -> Customize -> Tabs, set to "Don't restore after quitting"
   Swipe to the History Panel, tap "Clear browsing history" and verify "Ok".
   Swipe back to Bookmarks and tap an item for a slow loading page.
      (I use "http://www.popehat.com/")
   Quickly navigate to Android "Recent Apps" and swipe shut Firefox.

   Re-open Firefox and observe that the favicon for that bookmark is now displayed generically.

At start of page load, we're writing a new history item for the page without a favicon_id, and closing the app prevents us from updating it onTabChanged(LINK_FAVICON) at completion of page load.

This routine just needs to be a little smarter so it falls through and returns the still-available favicon from the Bookmark item.

Comment 1

[Chris Kitching [:ckitching]]

Comment on attachment 8501903 [details] [diff] [review]
bookmarkFaviconBug.diff

Review of attachment 8501903 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. We should've spotted this sooner!

Comment 2

[Mark Capella [:capella]]

Caught on the release train :)
try push https://tbpl.mozilla.org/?tree=Try&rev=68b57daf8209

Comment 3

[Chris Kitching [:ckitching]]

(In reply to Mark Capella [:capella] from comment #2)
> Caught on the release train :)
> try push https://tbpl.mozilla.org/?tree=Try&rev=68b57daf8209

Probably. Going to need to poke an actual peer before I can land it.

rnewman: I can haz land?

Comment 4

[Richard Newman [:rnewman]]

Use c.isNull(index) instead of (or as well as) relying on getString(index) returning null. Then you can land :)

Comment 5

[Mark Capella [:capella]]

Nit fixed, carried over r+

https://hg.mozilla.org/integration/fx-team/rev/800257dc7f64

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/800257dc7f64