Closed
Bug 1080016
Opened 10 years ago
Closed 10 years ago
Display favicons properly after interrupted page loads
Categories
(Firefox for Android Graveyard :: Favicon Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: capella, Assigned: capella)
Details
Attachments
(1 file)
1.28 KB,
patch
|
ckitching
:
review+
|
Details | Diff | Splinter Review |
This fixes a small display issue. STR to observe the issue is simple: In Settings -> Customize -> Tabs, set to "Don't restore after quitting" Swipe to the History Panel, tap "Clear browsing history" and verify "Ok". Swipe back to Bookmarks and tap an item for a slow loading page. (I use "http://www.popehat.com/") Quickly navigate to Android "Recent Apps" and swipe shut Firefox. Re-open Firefox and observe that the favicon for that bookmark is now displayed generically. At start of page load, we're writing a new history item for the page without a favicon_id, and closing the app prevents us from updating it onTabChanged(LINK_FAVICON) at completion of page load. This routine just needs to be a little smarter so it falls through and returns the still-available favicon from the Bookmark item.
Attachment #8501903 -
Flags: review?(chriskitching)
Comment 1•10 years ago
|
||
Comment on attachment 8501903 [details] [diff] [review] bookmarkFaviconBug.diff Review of attachment 8501903 [details] [diff] [review]: ----------------------------------------------------------------- Good catch. We should've spotted this sooner!
Attachment #8501903 -
Flags: review?(chriskitching) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Caught on the release train :) try push https://tbpl.mozilla.org/?tree=Try&rev=68b57daf8209
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
(In reply to Mark Capella [:capella] from comment #2) > Caught on the release train :) > try push https://tbpl.mozilla.org/?tree=Try&rev=68b57daf8209 Probably. Going to need to poke an actual peer before I can land it. rnewman: I can haz land?
Flags: needinfo?(rnewman)
Comment 4•10 years ago
|
||
Use c.isNull(index) instead of (or as well as) relying on getString(index) returning null. Then you can land :)
Flags: needinfo?(rnewman)
Assignee | ||
Comment 5•10 years ago
|
||
Nit fixed, carried over r+ https://hg.mozilla.org/integration/fx-team/rev/800257dc7f64
https://hg.mozilla.org/mozilla-central/rev/800257dc7f64
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•