1080046 - Export PK11_SetPublicKeyNickname and PK11_SetPrivateKeyNickname from nss3.dll

Status: RESOLVED WONTFIX

(Core :: Security, defect)

Description

[Sean Leonard]

Attachment: nss.patch

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

Tried to set public and private key nicknames (PKCS #11 CKA_LABEL attributes) with Mozilla NSS exported functions PK11_SetPublicKeyNickname and PK11_SetPrivateKeyNickname.


Actual results:

On Mac OS X and Linux, these functions are exported, so our calls work fine. However, on Windows it appears that as of Firefox 33.0b7 (i.e., mozilla-beta) or earlier, these functions are no longer exported.


Expected results:

It should be the same on all platforms: PK11_SetPublicKeyNickname and PK11_SetPrivateKeyNickname should be exported. Note that they both call PK11_SetObjectNickname but that has always been an internal function.

Attached is a patch to nss.def (in /security/build) to restore these functions.

Comment 1

[Sean Leonard]

Hello Mozilla security folks--
I spent a lot of effort updating our add-on for Firefox 33, but it would be very helpful for these two functions to be exported (in Windows), at least until we can work out some kind of alternative. We are trying to do the best that we can, but this help would be really appreciated.

Thank you for your time.

Comment 2

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8501934 [details] [diff] [review]
nss.patch

Review of attachment 8501934 [details] [diff] [review]:
-----------------------------------------------------------------

In general, this is fine. However, the patch needs to be properly formatted: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F (in particular, the patch should be from the root of the source tree).
Please prepare a patch for mozilla-central first (where the file in question is config/external/nss/nss.def). After we check that in, we can prepare branch patches (where, in beta at least, the file in question is security/build/nss.def). If/when those get uplift approval, we'll check them in. If we move quickly, we might be able to ship this in 33.

Comment 3

[:Cykesiopka]

Hi Sean,

Is this still needed?

Thanks.

Comment 4

[:Cykesiopka]

Actually, it looks like we no longer support binary add-ons in general.

Sorry for the bug spam.