1080160 - Integrate Composite Times into Telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Track and measure composite times in telemetry.

Comment 1

[Avi Halachmi (:avih)]

Adding for reference bug 1048667 comment 132 and 133 (discussion on what metrics to measure).

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Integrate Composite Times into Telemetry

Integrate composite times into telemetry using a histogram. Set a cap at a 1 second maximum measurement to composite.

Comment 3

[Benoit Girard (:BenWa)]

This looks ok but wont be useful for Silk as its written.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8532341 [details] [diff] [review]
Integrate Composite Times into Telemetry

Looks good but please get a review on Histograms.json changes. I asked in #perf but I haven't gotten a response yet. I wonder if the high of 1000 is too high for composite times which should rarely be in that range if it's at the cost of precision.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8532341 [details] [diff] [review]
Integrate Composite Times into Telemetry

From comment 4, asking :avih to review. He said the exponential scale should be good. Here is an example with a range of 0-10K and 50 buckets:

http://telemetry.mozilla.org/#filter=nightly%2F37%2FFX_REFRESH_DRIVER_FRAME_DELAY_MS&aggregates=multiselect-all!Submissions!Mean!5th%20percentile!25th%20percentile!median!75th%20percentile!95th%20percentile&evoOver=Builds&locked=true&sanitize=true&renderhistogram=Table

Comment 6

[Vladan Djeric (:vladan)]

(In reply to Benoit Girard (:BenWa) from comment #4)
> Looks good but please get a review on Histograms.json changes. I asked in
> #perf but I haven't gotten a response yet. I wonder if the high of 1000 is
> too high for composite times which should rarely be in that range if it's at
> the cost of precision.

Depends on what kind of granularity you need.. This is another exponential histogram with high of 1000  and 50 buckets: http://mzl.la/1sdX4RN

Comment 7

[Benoit Girard (:BenWa)]

That's look good. It would better if 15,16,17 weren't shared at all but the resolution should be fine.

Comment 8

[Mason Chang [Inactive] [:mchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/731e8e1a0494

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/731e8e1a0494