1080268 - try: Deploy taskcluster-try

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

taskcluster-try is already written and when pulse messages about new result-sets from treeherder is arriving we should deploy it.

Comment 1

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: bz://1080268/lightsofapollo

Comment 2

[James Lal [:lightsofapollo]]

/r/1385 - Bug 1080268 - Part 1 update try graph to use correct schema.
/r/1387 - Bug 1080268 - Part 2 Add scheduler id for builds.
/r/1389 - Bug 1080268 - Part 3 When --extend-graph is passed do not include metadata or scopes.
/r/1391 - Bug 1080268 - Part 4 refactor tests to use common inheritance.

Pull down these commits:

hg pull review -r fe65637ce544cccf9eb09cc164222172da627354

Comment 3

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/1383/#review809

::: testing/taskcluster/tasks/build.yml
(Diff revision 1)
>  task:

Nothing that was introduced with this patch, but I think for us to see the results in treeherder, we need routes added to all tasks in the graph like:

  routes:
    - 'treeherder.{{project}}.{{revision}}'

::: testing/taskcluster/tasks/decision/try.yml
(Diff revision 1)
> -taskId: '{{ "decision task" | as-slugid }}'
> +metadata:

Will there be a separate PR for taskcluster-try that will include this decision task in the config?

::: testing/taskcluster/tasks/decision/try.yml
(Diff revision 1)
> +  - "docker-worker:image:quay.io/mozilla/decision:0.0.3"

I'm still digging into the taskcluster scheduler documentation/code but Jonas was thinking it might be possible that the decision task just has a scope of extending a graph, and then all the scopes could be in the graph that's beeing added perhaps (taken care of by taskcluster-trygraph).

Comment 4

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/1383/#review827

> Nothing that was introduced with this patch, but I think for us to see the results in treeherder, we need routes added to all tasks in the graph like:
> 
>   routes:
>     - 'treeherder.{{project}}.{{revision}}'

Actually this should be {{revision_hash}} which will be available after bug 1109890 is fixed

Comment 5

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/1383/#review871

> Actually this should be {{revision_hash}} which will be available after bug 1109890 is fixed

This bug has been fixes.  Tasks should be able to have this route now and hopefully can report back to treeherder, or at least have the route to do so.

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8534073 [details]
MozReview Request: bz://1080268/lightsofapollo

r+ with comments in the review

Comment 7

[James Lal [:lightsofapollo]]

Splitting off initial code from this review to 1111980 which I will land (without comments) then address the comments you made here and push my server side changes.

Comment 8

[James Lal [:lightsofapollo]]

Attachment: https://github.com/taskcluster/taskcluster-try/pull/2

Imperfect but working changes needed for deployment primarily this is just some small tuning (and for now removing scope lock down)

Comment 9

[Greg Arndt [:garndt]]

Comment on attachment 8537031 [details] [review]
https://github.com/taskcluster/taskcluster-try/pull/2

r+ .  Minor comments added to the PR.  Also, thanks for correcting the misplaced route in the tests.

Comment 10

[James Lal [:lightsofapollo]]

The plan changed somewhat but the code is now deployed (and lives here https://github.com/taskcluster/mozilla-taskcluster)

Comment 11

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...