1080281 - client: Support unbindQueue in PulseListener

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

We should support unbinding a queue from an exchange.
This might be useful for docker-worker depending on whether or not it reuses workerIds.

Comment 1

[Greg Arndt [:garndt]]

This would be useful for the case where we want to stop listening for task-pending messages, but do not want to close the listener because we might be still using the channel.

Such as when we do not want to claim anymore tasks, but we want to finish up the tasks we have and ack the message after completion.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

@garndt,
It agree this would be useful in some cases.
But just to clarify, after queue rewrite we should not be listening for task-pending messages in
the worker. Also so note that some of these things can be done by listener.pause().
 - just trying to minimize confusion :)

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

We'll need this for tc-hooks to listen to pulse..

Comment 4

[:Eli Perelman]

Will this need to be implemented for the WebListener in taskcluster-client-web as well?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

No, I don't think so -- those are all non-durable queues anyway.

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

@coop: How is this stability related?

@dustin, tc-hooks doesn't strictly need it, it can just delete queue and re-create it. Granted this would cause messages to be dropped. But given that we can't reliably list neither queues or bindings we short of end up with something like that..

We could also used a queue per binding, then this is the same problem as with queues. Which taskcluster-pulse will eventually fix by providing an API for listing queues.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, I guess I misunderstood.

Comment 8

[Chris Cooper [:coop] (he/him)]

I just added all the pulse-related dependencies that got flagged yesterday. If this one isn't going to improve stability, we can drop it as part of that initiative.

Comment 9

[Yash Goyal]

Hi. I would like to work on this bug. Please help me get started.

Comment 10

[:Eli Perelman]

Jonas, is this going to be taken care of in the GSOC work?

Comment 11

[Jonas Finnemann Jensen (:jonasfj)]

The idea in GSoC is to drop the unbindQueue stuff, even reconnect from the WebListener, and make it as lot simpler, instead focusing on robustness.

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

OK -- and tc-lib-pulse already has unbind.