Closed Bug 1080432 Opened 10 years ago Closed 10 years ago

[Loop] [Feedback] Rate button should be disabled when no option has been checked

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: monica.meika, Assigned: crdlc)

References

Details

(Whiteboard: [mobile app][not blocking][tef-triage][patch available])

Attachments

(4 files)

rate.png
29.31 KB, image/png
Details
Github pull request
204 bytes, text/html
borjasalguero
: review+
Details
noselected_with_patch.png
40.09 KB, image/png
vicky
: ui-review+
monica.meika
: ui-review+
Details
selected_with_patch.png
40.64 KB, image/png
vicky
: ui-review+
monica.meika
: ui-review+
Details
Attached image rate.png — 
      No description provided.
Blocks: 1036490
Severity: normal → minor
Whiteboard: [mobile app][not blocking][tef-triage]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request — 
Thanks Borja
Attachment #8502428 - Flags: review?(borja.bugzilla)
with Cristian's patch, without selecting any option
Attachment #8502456 - Flags: ui-review?(vpg)
Attachment #8502456 - Flags: ui-review?(monica.meika)
Attached image selected_with_patch.png — 
with Cristian's patch, one option selected
Attachment #8502457 - Flags: ui-review?(vpg)
Attachment #8502457 - Flags: ui-review?(monica.meika)
Whiteboard: [mobile app][not blocking][tef-triage] → [mobile app][not blocking][tef-triage][patch available]
Attachment #8502457 - Flags: ui-review?(vpg) → ui-review+
Perfect :)
Attachment #8502457 - Flags: ui-review+
Attachment #8502456 - Flags: ui-review+
Attachment #8502456 - Flags: ui-review?(vpg) → ui-review+
Attachment #8502456 - Flags: ui-review?(monica.meika) → ui-review-
Attachment #8502456 - Flags: ui-review-
Attachment #8502457 - Flags: ui-review?(monica.meika)
Comment on attachment 8502428 [details]
Github pull request

Small things to be fixed before landing. Thanks!
Attachment #8502428 - Flags: review?(borja.bugzilla) → review+
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/1839984e30f007bb66c772fae96c3316fd1366b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Tested and working
Flame
eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , aba155c
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: