1080480 - [Messages] Use BroadcastChannel API instead of SharedWorker for inter instance communication

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

In bug 1058459 we've introduced SharedWorker-based workaround to support communication between app instances. 

Using BroadcastChannel API is much better approach to handle this, so once it's implemented we should use it instead.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL (WIP)

WIP PR based on the latest InterInstanceEventDispatcher from patch for bug 1105548 - seems that all cases work perfectly with BroadcastChannel

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1080480-broadcast-channel-master > mozilla-b2g:master

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8571916 [details] [review]
[gaia] azasypkin:bug-1080480-broadcast-channel-master > mozilla-b2g:master

Hey Steve,

Here is the patch that removes all SharedWorker-related stuff and use BroadcastChannel API. It's pretty stable already and much more lightweight so that it should affect performance in a positive way.

Thanks!

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8571916 [details] [review]
[gaia] azasypkin:bug-1080480-broadcast-channel-master > mozilla-b2g:master

Looks great after broadcast-channel API applied :) Just a minor suggestion so r=me. Thanks!

Comment 5

[Oleg Zasypkin [:azasypkin]]

Thanks for review! Suggestion added and Treeherder is green.

Master: https://github.com/mozilla-b2g/gaia/commit/83a88c1cab569c5503aad3f4cf09236d91a268a3