Closed Bug 1080480 Opened 5 years ago Closed 5 years ago

[Messages] Use BroadcastChannel API instead of SharedWorker for inter instance communication

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

Attachments

(2 files)

In bug 1058459 we've introduced SharedWorker-based workaround to support communication between app instances. 

Using BroadcastChannel API is much better approach to handle this, so once it's implemented we should use it instead.
WIP PR based on the latest InterInstanceEventDispatcher from patch for bug 1105548 - seems that all cases work perfectly with BroadcastChannel
Comment on attachment 8571916 [details] [review]
[gaia] azasypkin:bug-1080480-broadcast-channel-master > mozilla-b2g:master

Hey Steve,

Here is the patch that removes all SharedWorker-related stuff and use BroadcastChannel API. It's pretty stable already and much more lightweight so that it should affect performance in a positive way.

Thanks!
Attachment #8571916 - Flags: review?(schung)
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
See Also: → 1140339
Comment on attachment 8571916 [details] [review]
[gaia] azasypkin:bug-1080480-broadcast-channel-master > mozilla-b2g:master

Looks great after broadcast-channel API applied :) Just a minor suggestion so r=me. Thanks!
Attachment #8571916 - Flags: review?(schung) → review+
Thanks for review! Suggestion added and Treeherder is green.

Master: https://github.com/mozilla-b2g/gaia/commit/83a88c1cab569c5503aad3f4cf09236d91a268a3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.