Closed
Bug 1080557
Opened 10 years ago
Closed 10 years ago
Update test_browser_bookmark.py to delete the bookmark added
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: viorela, Unassigned)
Details
Attachments
(2 files)
Test test_browser_bookmark.py is currently adding a bookmark to homescreen.
We should update it to delete that bookmark, as per testcase https://moztrap.mozilla.org/manage/case/13158/
After deleting it, we need to check that the bookmark is no longer present on the homescreen.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8503108 -
Flags: review?(robert.chira)
Attachment #8503108 -
Flags: review?(gmealer)
Attachment #8503108 -
Flags: review?(florin.strugariu)
|
||
Updated•10 years ago
|
Attachment #8503108 -
Flags: review?(florin.strugariu) → review+
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8503108 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25023
Test runs nice, butplease address the comment in the PR
Attachment #8503108 -
Flags: review?(robert.chira) → review-
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8503108 -
Flags: review- → review?(robert.chira)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8503108 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25023
Merged on master:
https://github.com/mozilla-b2g/gaia/commit/41e9fe1d63c41cd357753a8cbcedab81de89134a
Viorela, does this need to be uplifted to 2.1?
Attachment #8503108 -
Flags: review?(robert.chira)
Attachment #8503108 -
Flags: review?(gmealer)
Attachment #8503108 -
Flags: review+
Flags: needinfo?(viorela.ioia)
|
|
Reporter | |
Comment 5•10 years ago
|
||
PR for v2.1
Attachment #8505359 -
Flags: review?(robert.chira)
Attachment #8505359 -
Flags: review?(florin.strugariu)
|
|
||
Updated•10 years ago
|
Attachment #8505359 -
Flags: review?(florin.strugariu) → review+
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8505359 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25173
Merged to v2.1:
https://github.com/mozilla-b2g/gaia/commit/9d5d4d838d4369dbae39f8e97550603046602a2e
Attachment #8505359 -
Flags: review?(robert.chira) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s1]
You need to log in
before you can comment on or make changes to this bug.
Description
•