Closed Bug 1080669 Opened 10 years ago Closed 10 years ago

Remove double-indent at resultset page boundary, optimize space

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

(
URL
)

Details

Attachments

(2 files)

resultset boundary
35.66 KB, image/jpeg
Details
treeherder-ui-PR#226
49 bytes, text/x-github-pull-request
camd
: review+
emorley
: feedback+
Details | Review 
I noticed this LHF in passing. The resultset page boundary has got some (I think unwanted) double indentation due to a couple bits of markup both receiving the same padding value.

In fixing we can increase page real estate a bit, and clean up the layout.

I'll attach a screen grab, and put up the tweak for consideration.
Attached image resultset boundary — 
See attached for the current appearance I'd like to improve.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file treeherder-ui-PR#226 — 
Please see the above PR for review and status. Checking with Ed for feedback prior to merge.
Attachment #8502688 - Flags: review?(cdawson)
Attachment #8502688 - Flags: feedback?(emorley)
Comment on attachment 8502688 [details] [review]
treeherder-ui-PR#226



Looks good! :-)
Attachment #8502688 - Flags: feedback?(emorley) → feedback+
Priority: P5 → P3
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/045a0cfc4cdf82ecfafdbfa61ea84663a4924865
Bug 1080669 - Clean up resultset boundary and optimize page space

https://github.com/mozilla/treeherder-ui/commit/2ebb18e215f28345dc1224f54e7ff8d68df1afb2
Merge pull request #226 from tojonmz/optimize-page-space

Bug 1080669 - Clean up resultset boundary and optimize page space
Attachment #8502688 - Flags: review?(cdawson) → review+
Verified fixed and working correctly on dev/stage. I also made the total job count button accommodate 1,000+ job counts with this PR. They look correct also.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b85535c8bf133d6a7a5cd80a6433d4c43594878f
Bug 1080669 - Clean up resultset boundary and optimize page space

https://github.com/mozilla/treeherder/commit/cd2420719222fe36464675bda530c8a2ca98bc4b
Merge pull request #226 from tojonmz/optimize-page-space

Bug 1080669 - Clean up resultset boundary and optimize page space
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: