1080737 - fte/ftu broken depending on locale (e.g. for German): Header 'Select a Network' stuck, contacts import and links broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Geeksphone Keon with Boot2Gecko 2.2.0.0-prerelease 20141009012329

After resetting the phone, depending on the locale I select on the first screen, I get the following issues if I select German (en-US works fine):
- After the screen to select a Wi-Fi network (German translation "Netzwerke"), the header "Netzwerke" is stuck.
- Tapping on the button to import contacts from the memory card shows a progress text that it is searching for networks.
- In the following screen, the links in the strings haven't been translated.

The issues are likely due to a stopped script execution, but it didn't see anything in the logcat (but it's after a reset, so I am not convinced that I catched everything).

Because it depends on the locale, I file it against Gaia::L10n

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also reproduces with Flame on 2.2.0.0-prerelease 20141009040206, but not on 2.1.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Assigning this to the QA wanted team to find a regression window here.

Comment 3

[Joshua Mitchell (Inactive)]

Here is my initial window - I will not be able to complete the B2G inbound (smaller) window until tomorrow

Central Regression Window:

Last Working:
Device: Flame Master
Build ID: 20141005093632
Gaia: 83f495a1c12687970f7f2840c2729795c4b88177
Gecko: 0ed32d9a42d6
Version: 35.0a1 (Master)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken:
Device: Flame Master
Build ID: 20141006040158
Gaia: 470826d13ae130a5c3d572d1029e595105485fb0
Gecko: e0d714f43edc
Version: 35.0a1 (Master)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Gaia/Gecko Swap
Last Working Gaia First Broken Gecko: Issue does not reproduce
Gaia: 83f495a1c12687970f7f2840c2729795c4b88177
Gecko: e0d714f43edc
First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 470826d13ae130a5c3d572d1029e595105485fb0
Gecko: 0ed32d9a42d6

GAIA pushlog: https://github.com/mozilla-b2g/gaia/compare/83f495a1c12687970f7f2840c2729795c4b88177...470826d13ae130a5c3d572d1029e595105485fb0

Comment 4

[Joshua Mitchell (Inactive)]

B2G-Inbound Regression Window:

Last Working:
Device: Flame Master
Build ID: 20141003223230
Gaia: 3d7c3b9155aead5fb214c80e96d2ded3d85441c1
Gecko: b336784e58f9
Version: 35.0a1 (Master)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken:
Device: Flame Master
Build ID: 20141004051230
Gaia: aee70e16d3f9a38043735e4571670e50b8a9a75a
Gecko: 6ebd2ef88a04
Version: 35.0a1 (Master)
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Gaia/Gecko Swap
Last Working Gaia First Broken Gecko: Issue does not reproduce
Gaia: 3d7c3b9155aead5fb214c80e96d2ded3d85441c1
Gecko: 6ebd2ef88a04
First Broken Gaia Last Working Gecko: Issue does reproduce
Gaia: aee70e16d3f9a38043735e4571670e50b8a9a75a
Gecko: b336784e58f9

GAIA pushlog: https://github.com/mozilla-b2g/gaia/compare/3d7c3b9155aead5fb214c80e96d2ded3d85441c1...aee70e16d3f9a38043735e4571670e50b8a9a75a

Broken by Bug #1058985 - can you take a look Gaurav?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

I verified the bug. 

Aryx, the bug is a result of a combination of two factors:
 - you need to update your localization
 - we temporarily throw on the exact error that your obsolete translation is causing

What's going on is as this:
 - in the FTU bug (bug 1058985) we updated the entity "networkLists" to "networksLists.ariaLabel" so that we can just set data-l10n-id on the node and it will set the attribute properly
 - in bug 1053629 we simplified the heuristics of Node translation to not allow setting text content on nodes with node children
 - we decided to temporarily throw on such errors because they are so hard to discover otherwise and we're very early in the 2.2 cycle. We plan to remove the throwing in a few weeks

In result of that combination your localization is attempting to set the content of the element and we throw which breaks the localization.

It's a bit tricky situation that we have here - we could easily put a try/catch to make sure that one entity like that doesn't break the whole UI localization, but I believe we're ok with it for another few weeks since it will help us discover regressions in a code that is extremely hard to find regressions in.

Aryx, you just need to update your translation of the FTU app to match 2.2 master :)

Comment 6

[Joshua Mitchell (Inactive)]

NI to draw reporter's attention to comment 5

Comment 7

[Sebastián Enrique Becerra Cancino]

Hi Guys,

Same is happening on Firefox OS 2.2 es-ES when I try to connect to a network in the password screen the title is not centered when I put the password and WiFi connects the next screens have the same title but centered. 
On Firefox OS 2.2 en-US the title keeps stuck on the "Language" title.

All this with the latest b2g-36.0a1.en-US on 14-Oct and Non-Engineer.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Sebastián Enrique Becerra Cancino from comment #7)
> Hi Guys,
> 
> Same is happening on Firefox OS 2.2 es-ES when I try to connect to a network
> in the password screen the title is not centered when I put the password and
> WiFi connects the next screens have the same title but centered. 
> On Firefox OS 2.2 en-US the title keeps stuck on the "Language" title.

Same reason: http://hg.mozilla.org/gaia-l10n/es/file/8907e555c5dd/apps/ftu/ftu.properties#l167

We need to wait for all locales to update that.

As I mentioned previously, this will not stay broken. Once the dust settles and we are sure we don't have any other regressions related to code we could not test, we will remove the throwing portion of the code and this will start working normally (missing entity but the rest will be localized properly)

Comment 9

[Axel Hecht [:Pike]]

gandalf, please change the ID in the code.

people rely on your reviews stating that this works with l10n as it is, and not as if you'd like to be. It's not acceptable that we're breaking the app for mishaps in the localization. Falling back to en-US is OK, but bustages are not.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The cause of the issue itself is being tracked in bug 1091113. The obsolete entities of the FTU app have been removed in http://hg.mozilla.org/gaia-l10n/de/rev/d2cec01f68b2 , so closing this bug.

Comment 11

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: Following Comment 0:
- The header changes properly.
- The correct strings appear. ("Von der Speicherkarte wird gelesen...", "Kontakte werden von der Speicherkarte importiert...")
- All pages are translated properly.

Device: Flame 2.2 (319mb, KK, Shallow Flash)
Build ID: 20141125040209
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 12

[bhavana bajaj [:bajaj]]

Clearing the blocking nom for 2.2? as this is already fixed/verified on that branch per the status flag